Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 651503002: Clean up forward declarations in Source/modules (Closed)

Created:
6 years, 2 months ago by zhaoze.zhou
Modified:
6 years, 2 months ago
CC:
Raymond Toy, blink-reviews, Inactive, cmumford, dgrogan, eric.carlson_apple.com, falken, feature-media-reviews_chromium.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+serviceworker, kinuko+fileapi, michaeln, mvanouwerkerk+watch_chromium.org, nhiroki, philipj_slow, serviceworker-reviews, timvolodine, tommyw+watchlist_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in Source/modules These forward references are not needed anymore. After this patch, Source/modules has no unneeded forward references any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183897

Patch Set 1 #

Total comments: 7

Patch Set 2 : add include file back #

Total comments: 7

Patch Set 3 : fix indexeddb #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -92 lines) Patch
M Source/modules/EventTargetModules.h View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/modules/credentialmanager/Credential.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/credentialmanager/CredentialManagerClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/CryptoKey.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_light/DeviceLightDispatcher.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionDispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationDispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeysClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystem.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/DOMFileSystemBase.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/Entry.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadDispatcher.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geofencing/Geofencing.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBFactory.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/WebIDBCallbacksImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaDevicesRequest.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamRegistry.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrackSourcesCallback.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/notifications/NotificationController.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushManager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/Headers.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallEvent.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionAlternative.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioBasicProcessorNode.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/Database.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseThread.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/DatabaseTracker.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseResource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatement.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/SQLStatementBackend.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/sqlite/SQLiteFileSystem.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webmidi/MIDIAccessInitializer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
rwlbuis
Looks good, adding mkwst for proper review.
6 years, 2 months ago (2014-10-10 22:29:42 UTC) #3
Mike West
I spot-checked the first few files; the forward declarations look fine to remove. I'm less ...
6 years, 2 months ago (2014-10-11 10:53:05 UTC) #4
zhaoze.zhou
https://codereview.chromium.org/651503002/diff/1/Source/modules/credentialmanager/Credential.h File Source/modules/credentialmanager/Credential.h (left): https://codereview.chromium.org/651503002/diff/1/Source/modules/credentialmanager/Credential.h#oldcode11 Source/modules/credentialmanager/Credential.h:11: #include "platform/heap/Handle.h" On 2014/10/11 10:53:05, Mike West wrote: > ...
6 years, 2 months ago (2014-10-13 16:51:00 UTC) #5
Raymond Toy
The two webaudio changes look fine to me.
6 years, 2 months ago (2014-10-13 16:57:22 UTC) #7
jsbell
Comments on modules/indexeddb https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBCursor.h File Source/modules/indexeddb/IDBCursor.h (left): https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBCursor.h#oldcode44 Source/modules/indexeddb/IDBCursor.h:44: class ExecutionContext; Can you also remove ...
6 years, 2 months ago (2014-10-13 18:43:22 UTC) #9
zhaoze.zhou
https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBFactory.h File Source/modules/indexeddb/IDBFactory.h (left): https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBFactory.h#oldcode42 Source/modules/indexeddb/IDBFactory.h:42: class ExecutionContext; On 2014/10/13 18:43:22, jsbell wrote: > ExecutionContext ...
6 years, 2 months ago (2014-10-13 19:17:15 UTC) #10
rwlbuis
On 2014/10/13 19:17:15, zhaoze.zhou wrote: > https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBFactory.h > File Source/modules/indexeddb/IDBFactory.h (left): > > https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBFactory.h#oldcode42 > ...
6 years, 2 months ago (2014-10-16 14:18:27 UTC) #11
Mike West
On 2014/10/16 14:18:27, rwlbuis wrote: > On 2014/10/13 19:17:15, zhaoze.zhou wrote: > > > https://codereview.chromium.org/651503002/diff/620001/Source/modules/indexeddb/IDBFactory.h ...
6 years, 2 months ago (2014-10-16 15:15:57 UTC) #12
Mike West
LGTM, thanks.
6 years, 2 months ago (2014-10-17 07:52:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651503002/940001
6 years, 2 months ago (2014-10-17 13:32:40 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 16:02:55 UTC) #16
Message was sent while issue was closed. 
Committed patchset #4 (id:940001) as 183897

Powered by Google App Engine
This is Rietveld 408576698