Clean up forward declarations in Source/modules

Source/modules/indexeddb/IDBFactory.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
 #define IDBFactory_h
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "modules/indexeddb/IDBOpenDBRequest.h"
 #include "modules/indexeddb/IndexedDBClient.h"
 #include "platform/heap/Handle.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
-class ExceptionState;

[jsbell, 2014/10/13 18:43:21]

This type appears to still be referenced. What's the rationale for removing the
forward declaration?

-class IDBKey;
-class IDBKeyRange;
 class ExecutionContext;

[jsbell, 2014/10/13 18:43:22]

ExecutionContext is not referenced and can be removed.

(But the ordering is wrong. Oops.)

On the other hand, ScriptState should be forward-declared.

[zhaoze.zhou, 2014/10/13 19:17:14]

Done.

 
 class IDBFactory final : public GarbageCollected<IDBFactory>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
     static IDBFactory* create(IndexedDBClient* client)
     {
         return new IDBFactory(client);
     }
     void trace(Visitor*);
 
     IDBRequest* getDatabaseNames(ScriptState*, ExceptionState&);
 
     IDBOpenDBRequest* open(ScriptState*, const String& name, ExceptionState&);
     IDBOpenDBRequest* open(ScriptState*, const String& name, unsigned long long version, ExceptionState&);
     IDBOpenDBRequest* deleteDatabase(ScriptState*, const String& name, ExceptionState&);
 
     short cmp(ScriptState*, const ScriptValue& first, const ScriptValue& second, ExceptionState&);
 
 private:
     explicit IDBFactory(IndexedDBClient*);
 
     IDBOpenDBRequest* openInternal(ScriptState*, const String& name, int64_t version, ExceptionState&);
 
     Member<IndexedDBClient> m_permissionClient;
 };
 
 } // namespace blink
 
 #endif // IDBFactory_h