Use no-op statistics collecting object for WebView

chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/base64.h"
@@ skipping 58 matching lines @@
       new MockDataReductionProxySettings<C>(flags);
   EXPECT_CALL(*settings, GetOriginalProfilePrefs())
       .Times(AnyNumber())
       .WillRepeatedly(Return(&pref_service_));
   EXPECT_CALL(*settings, GetLocalStatePrefs())
       .Times(AnyNumber())
       .WillRepeatedly(Return(&pref_service_));
   EXPECT_CALL(*settings, GetURLFetcherForAvailabilityCheck()).Times(0);
   EXPECT_CALL(*settings, LogProxyState(_, _, _)).Times(0);
   settings_.reset(settings);
-  settings_->SetDataReductionProxyStatisticsPrefs(statistics_prefs_.get());
+  settings_->SetDataReductionProxyStatistics(statistics_prefs_.get());

[sgurun-gerrit only, 2014/10/17 20:29:38]

why change name?

[hush (inactive), 2014/10/17 21:19:47]

the idea of the base class "DataReductionProxyStatistics" is that it is an
object that contains the drp stats, regardless of what is used to implement it.
DataReductionProxyStatisticsPrefs writes the stats into pref_service, but it is
an implementation detail.
I don't feel too strongly about this though.. If you guys don't like this name,
I will keep it and have a smaller CL

 }
 
 template <class C>
 void data_reduction_proxy::DataReductionProxySettingsTestBase::SetProbeResult(
     const std::string& test_url,
     const std::string& response,
     ProbeURLFetchResult result,
     bool success,
     int expected_calls)  {
   MockDataReductionProxySettings<C>* settings =
@@ skipping 97 matching lines @@
 
   jlong value;
   for (size_t i = 0; i < data_reduction_proxy::kNumDaysInHistory; ++i) {
     env_->GetLongArrayRegion(result.obj(), i, 1, &value);
     ASSERT_EQ(
         static_cast<long>(
             (data_reduction_proxy::kNumDaysInHistory - 1 - i) * 2), value);
   }
 }