Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Unified Diff: ui/file_manager/file_manager/foreground/js/metrics.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metrics.js
diff --git a/ui/file_manager/file_manager/foreground/js/metrics.js b/ui/file_manager/file_manager/foreground/js/metrics.js
index 7760483503973ddc5d28fec845a3348c3b992ecd..a59491d7b489192dd1661efd77c3f6a03f933091 100644
--- a/ui/file_manager/file_manager/foreground/js/metrics.js
+++ b/ui/file_manager/file_manager/foreground/js/metrics.js
@@ -94,8 +94,8 @@ metrics.recordInterval = function(name) {
* Record an enum value.
*
* @param {string} name Metric name.
- * @param {Object} value Enum value.
- * @param {Array.<Object>|number} validValues Array of valid values
+ * @param {*} value Enum value.
+ * @param {Array.<*>|number} validValues Array of valid values
* or a boundary number value.
*/
metrics.recordEnum = function(name, value, validValues) {
@@ -105,7 +105,7 @@ metrics.recordEnum = function(name, value, validValues) {
index = validValues.indexOf(value);
boundaryValue = validValues.length;
} else {
- index = value;
+ index = /** @type {number} */ (value);
boundaryValue = validValues;
}
// Collect invalid values in the overflow bucket at the end.

Powered by Google App Engine
This is Rietveld 408576698