Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
index 0d1b46896623d4ac72c1ef109dc0aa68ef194ade..8de5921ed121113198be5350a54a533484ce1f31 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js
@@ -710,6 +710,7 @@ MetadataProvider.prototype.fetch = function(entry, type, callback) {
* This provider returns the following objects:
* filesystem: { size, modificationTime }
* @constructor
+ * @extends {MetadataProvider}
*/
function FilesystemProvider() {
MetadataProvider.call(this);
@@ -772,6 +773,7 @@ FilesystemProvider.prototype.fetch = function(
* thumbnail: { url, transform }
* @param {VolumeManagerWrapper} volumeManager Volume manager instance.
* @constructor
+ * @extends {MetadataProvider}
*/
function ExternalProvider(volumeManager) {
MetadataProvider.call(this);
@@ -800,8 +802,10 @@ ExternalProvider.prototype = {
*/
ExternalProvider.prototype.supportsEntry = function(entry) {
var locationInfo = this.volumeManager_.getLocationInfo(entry);
- return locationInfo && (locationInfo.isDriveBased ||
- locationInfo.rootType === VolumeManagerCommon.RootType.PROVIDED);
+ if (!locationInfo)
+ return false;
+ return locationInfo.isDriveBased ||
+ locationInfo.rootType === VolumeManagerCommon.RootType.PROVIDED;
};
/**
@@ -918,6 +922,7 @@ ExternalProvider.prototype.convert_ = function(data, entry) {
* media: { artist, album, title, width, height, imageTransform, etc. }
* fetchedMedia: { same fields here }
* @constructor
+ * @extends {MetadataProvider}
*/
function ContentProvider() {
MetadataProvider.call(this);
@@ -958,7 +963,7 @@ ContentProvider.prototype = {
* @return {boolean} Whether this provider supports the entry.
*/
ContentProvider.prototype.supportsEntry = function(entry) {
- return entry.toURL().match(this.urlFilter_);
+ return !!entry.toURL().match(this.urlFilter_);
};
/**

Powered by Google App Engine
This is Rietveld 408576698