ui/file_manager/file_manager/foreground/js/navigation_list_model.js - Issue 651403002: Fix trivial type-check errors in file_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/navigation_list_model.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/metrics.js ('k') | ui/file_manager/file_manager/foreground/js/progress_center_item_group.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/navigation_list_model.js

diff --git a/ui/file_manager/file_manager/foreground/js/navigation_list_model.js b/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

index 33c68809f005c030fcc9c10f2449b71a82d0c0d2..62b031d9ea59072f4c3f314794dd95d6699703d0 100644

--- a/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

+++ b/ui/file_manager/file_manager/foreground/js/navigation_list_model.js

@@ -82,7 +82,8 @@ NavigationModelVolumeItem.prototype = {

/**

* A navigation list model. This model combines the 2 lists.

* @param {VolumeManagerWrapper} volumeManager VolumeManagerWrapper instance.

- * @param {cr.ui.ArrayDataModel} shortcutListModel The list of folder shortcut.

+ * @param {(cr.ui.ArrayDataModel|FolderShortcutsDataModel)} shortcutListModel

+ * The list of folder shortcut.

* @constructor

* @extends {cr.EventTarget}

@@ -122,7 +123,7 @@ function NavigationListModel(volumeManager, shortcutListModel) {

this.shortcutList_ = [];

for (var i = 0; i < this.shortcutListModel_.length; i++) {

- var shortcutEntry = this.shortcutListModel_.item(i);

+ var shortcutEntry = /** @type {Entry} */ (this.shortcutListModel_.item(i));

var volumeInfo = this.volumeManager_.getVolumeInfo(shortcutEntry);

this.shortcutList_.push(entryToModelItem(shortcutEntry));

}