Make HTML5 <mark> accessible.

Make HTML5 <mark> accessible.

According to latest editor's draft http://w3c.github.io/aria/html-aam/html-aam.html#el-mark
mark tag has to be exposed as

Win
MSAA + IA2 IA2_ROLE_TEXT_FRAME

Mac
AXRole: AXGroup
AXSubrole: ?
AXRoleDescription: "highlighted content"

This CL depends on https://codereview.chromium.org/653683005/

BUG=421790
Committed: https://crrev.com/cfc36461f4cdfd039355ff39b6a5cc64dab63ce3
Cr-Commit-Position: refs/heads/master@{#335055}

[shreeramk, 2015-06-11 04:45:12]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2015-06-11 04:45:13]

PTAL. Thanks!

[shreeramk, 2015-06-12 06:07:51]

shreeram.k@samsung.com changed reviewers:
+ je_julie.kim@samsung.com

[je_julie(Not used), 2015-06-12 09:23:50]

On 2015/06/11 04:45:13, shreeramk wrote:
> PTAL. Thanks!

lgtm.

[rwlbuis, 2015-06-12 16:21:08]

On 2015/06/12 09:23:50, je_julie wrote:
> On 2015/06/11 04:45:13, shreeramk wrote:
> > PTAL. Thanks!
> 
> lgtm.

@je_julie, as non OWNER it is better to not use lgtm to prevent confusion :)
Saying something like "peer review looks good to me" would prevent it.

I think we still need an ok from dmazzoni for this reason.

[dmazzoni, 2015-06-12 16:32:28]

Julie is a full committer and she's familiar with this code, so I think an
lgtm is appropriate.

Of course it needs an lgtm from an owner to commit.

On Fri, Jun 12, 2015 at 9:21 AM <rob.buis@samsung.com> wrote:

> On 2015/06/12 09:23:50, je_julie wrote:
> > On 2015/06/11 04:45:13, shreeramk wrote:
> > > PTAL. Thanks!
>
> > lgtm.
>
> @je_julie, as non OWNER it is better to not use lgtm to prevent confusion
> :)
> Saying something like "peer review looks good to me" would prevent it.
>
> I think we still need an ok from dmazzoni for this reason.
>
> https://codereview.chromium.org/651133003/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-06-12 16:33:42]

lgtm

[dmazzoni, 2015-06-12 16:34:05]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-06-12 16:34:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651133003/100001

[commit-bot: I haz the power, 2015-06-12 16:43:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-12 16:43:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[je_julie(Not used), 2015-06-13 00:24:46]

Dominic and Rob, Thanks for your comment.
@shreeramk, this CL needs to get a review from an owner for content_strings.grd.

On 2015/06/12 16:32:28, dmazzoni wrote:
> Julie is a full committer and she's familiar with this code, so I think an
> lgtm is appropriate.
> 
> Of course it needs an lgtm from an owner to commit.
> 
> On Fri, Jun 12, 2015 at 9:21 AM <mailto:rob.buis@samsung.com> wrote:
> 
> > On 2015/06/12 09:23:50, je_julie wrote:
> > > On 2015/06/11 04:45:13, shreeramk wrote:
> > > > PTAL. Thanks!
> >
> > > lgtm.
> >
> > @je_julie, as non OWNER it is better to not use lgtm to prevent confusion
> > :)
> > Saying something like "peer review looks good to me" would prevent it.
> >
> > I think we still need an ok from dmazzoni for this reason.
> >
> > https://codereview.chromium.org/651133003/

[shreeramk, 2015-06-13 05:14:11]

@avi: OWNER lgtm for changes in content_strings.grd Thanks!

[shreeramk, 2015-06-13 05:14:39]

shreeram.k@samsung.com changed reviewers:
+ avi@chromium.org

[shreeramk, 2015-06-18 09:00:22]

On 2015/06/13 05:14:11, shreeramk wrote:
> @avi: OWNER lgtm for changes in content_strings.grd Thanks!

@Dominic: Could you please add OWNER reviewer for contents/ ?

[Avi (use Gerrit), 2015-06-18 14:33:36]

content/app/strings/content_strings.grd lgtm

[dmazzoni, 2015-06-18 14:47:54]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-06-18 14:50:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/651133003/100001

[commit-bot: I haz the power, 2015-06-18 16:10:37]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-06-18 16:12:07]

Patchset 6 (id:??) landed as
https://crrev.com/cfc36461f4cdfd039355ff39b6a5cc64dab63ce3
Cr-Commit-Position: refs/heads/master@{#335055}

[Jess, 2015-06-19 18:38:26]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1197713006/ by jessicag@chromium.org.

The reason for reverting is: Primary suspect for top windows canary crasher.

https://code.google.com/p/chromium/issues/detail?id=502311.

[shreeramk, 2015-06-21 06:13:50]

Is this CL un-reverted?

[dmazzoni, 2015-06-22 19:25:51]

The revert didn't go through, we reverted the right one.

On Sat, Jun 20, 2015 at 11:13 PM <shreeram.k@samsung.com> wrote:

> Is this CL un-reverted?
>
> https://codereview.chromium.org/651133003/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.