Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 650573002: emitIAS for the couple of blend instructions. (Closed)

Created:
6 years, 2 months ago by jvoung (off chromium)
Modified:
6 years, 2 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : format #

Total comments: 2

Patch Set 3 : remove isa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -8 lines) Patch
M src/IceInstX8632.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceInstX8632.cpp View 1 2 3 chunks +27 lines, -1 line 0 comments Download
M src/assembler_ia32.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/assembler_ia32.cpp View 1 1 chunk +38 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-select.ll View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
6 years, 2 months ago (2014-10-10 23:55:32 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/650573002/diff/70001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/650573002/diff/70001/src/IceInstX8632.cpp#newcode1084 src/IceInstX8632.cpp:1084: assert(llvm::isa<Variable>(Inst->getSrc(2))); Won't the cast include the isa test?
6 years, 2 months ago (2014-10-13 16:07:32 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/650573002/diff/70001/src/IceInstX8632.cpp File src/IceInstX8632.cpp (right): https://codereview.chromium.org/650573002/diff/70001/src/IceInstX8632.cpp#newcode1084 src/IceInstX8632.cpp:1084: assert(llvm::isa<Variable>(Inst->getSrc(2))); On 2014/10/13 16:07:32, stichnot wrote: > Won't the ...
6 years, 2 months ago (2014-10-13 21:04:00 UTC) #4
jvoung (off chromium)
6 years, 2 months ago (2014-10-13 21:06:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:200001) manually as
d026c448e8b6c527fee99bad5abc6070bf8fc740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698