Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 65043004: Add better handle tracking, and optimize Connector::Accept. (Closed)

Created:
7 years, 1 month ago by darin (slow to review)
Modified:
7 years, 1 month ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Add better handle tracking, and optimize Connector::Accept. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234056

Patch Set 1 #

Patch Set 2 : Improvements #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Update per review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -25 lines) Patch
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/lib/connector.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/lib/connector.cc View 1 2 3 2 chunks +38 lines, -18 lines 0 comments Download
M mojo/public/bindings/lib/message.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/public/bindings/lib/message.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/bindings/lib/message_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tests/bindings_connector_unittest.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
7 years, 1 month ago (2013-11-08 04:46:18 UTC) #1
viettrungluu
LGTM w/nit. https://codereview.chromium.org/65043004/diff/120001/mojo/public/bindings/lib/connector.cc File mojo/public/bindings/lib/connector.cc (right): https://codereview.chromium.org/65043004/diff/120001/mojo/public/bindings/lib/connector.cc#newcode43 mojo/public/bindings/lib/connector.cc:43: if (wait_to_write) { I assume that wait_to_write ...
7 years, 1 month ago (2013-11-08 20:18:38 UTC) #2
darin (slow to review)
On Fri, Nov 8, 2013 at 12:18 PM, <viettrungluu@chromium.org> wrote: > LGTM w/nit. > > ...
7 years, 1 month ago (2013-11-08 21:10:42 UTC) #3
darin (slow to review)
7 years, 1 month ago (2013-11-09 01:02:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r234056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698