mojo/public/bindings/lib/message.cc - Issue 65043004: Add better handle tracking, and optimize Connector::Accept.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/bindings/lib/message.cc

Issue 65043004: Add better handle tracking, and optimize Connector::Accept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update per review feedback Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/bindings/lib/message.cc

diff --git a/mojo/public/bindings/lib/message.cc b/mojo/public/bindings/lib/message.cc

index b1637cc049d5e6b8641e77fb03890551f3815de8..4f6b6be3b232e906b6cb7ba8d0c6ed9c44787e6e 100644

--- a/mojo/public/bindings/lib/message.cc

+++ b/mojo/public/bindings/lib/message.cc

@@ -16,7 +16,7 @@ Message::Message()

Message::~Message() {

free(data);

- // TODO(darin): Need to Close any handles so they don't leak.

+ std::for_each(handles.begin(), handles.end(), Close);

}

void Message::Swap(Message* other) {

« no previous file with comments | « mojo/public/bindings/lib/message.h ('k') | mojo/public/bindings/lib/message_queue.h » ('j') | no next file with comments »