CQ: catch IOError thrown on socket timeouts

CQ: catch IOError thrown on socket timeouts

BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=233950

[M-A Ruel, 2013-11-07 19:36:04]

lgtm if both still work

https://codereview.chromium.org/64983002/diff/1/commit-queue/verification/try...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/64983002/diff/1/commit-queue/verification/try...
commit-queue/verification/try_job_on_rietveld.py:756: except socket.error as e:
I think socket.error inherits from IOError, so this code will never be executed.
Right? I'd recommend to reverse the order anyway.

[Paweł Hajdan Jr., 2013-11-07 21:02:16]

https://codereview.chromium.org/64983002/diff/1/commit-queue/verification/try...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/64983002/diff/1/commit-queue/verification/try...
commit-queue/verification/try_job_on_rietveld.py:756: except socket.error as e:
On 2013/11/07 19:36:05, M-A Ruel wrote:
> I think socket.error inherits from IOError, so this code will never be
executed.
> Right? I'd recommend to reverse the order anyway.

In my tests it didn't behave that way. I think sometimes python makes IOError
wrap socket.error or something similar.

Reversed the order for now. I'll test some more though.

[commit-bot: I haz the power, 2013-11-08 19:00:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/64983002/60001

[commit-bot: I haz the power, 2013-11-08 19:01:12]

Change committed as 233950

[Vadim Sh., 2013-11-08 19:33:56]

I'm sorry I'm jumping into the review uninvited and late, but I have couple
comments.

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
commit-queue/verification/try_job_on_rietveld.py:750: except socket.error as e:
When making HTTPS requests with client-side timeout urllib2 raises ssl.SSLError
(that's completely unrelated to IOError or socket.error). I think you need to
catch it too.

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
commit-queue/verification/try_job_on_rietveld.py:752: if e.errno ==
errno.ECONNRESET:
It'll only catch timeouts while opening a connection.

If connection was established, but socket.read() later times out, it's a
different exception (socket.timeout I think, that's inherited from
socket.error).

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
commit-queue/verification/try_job_on_rietveld.py:759: if e.errno == 'socket
error':
errno is a string?.. How can this happen?

[Paweł Hajdan Jr., 2013-11-08 20:14:18]

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/64983002/diff/60001/commit-queue/verification...
commit-queue/verification/try_job_on_rietveld.py:759: if e.errno == 'socket
error':
On 2013/11/08 19:33:57, Vadim Sh. wrote:
> errno is a string?.. How can this happen?

I believe it can. All of this is based on what I've seen happening.

When I see the other errors I'll add appropriate error handling. I prefer not to
be too speculative about this.

[Isaac (away), 2013-11-08 21:51:13]

Is your client up to date?  I'm still not getting CCed on your CQ changes,
despite being in watchlists on both tools and commit-queue.

http://src.chromium.org/chrome/trunk/tools/WATCHLISTS
http://src.chromium.org/chrome/trunk/tools/commit-queue/WATCHLISTS

This has happened a number of times with your CLs, and is in part occurring
because you're using a non-recommended SCM setup.  Please explicitly CC
ilevy-cc@chromium on new CQ changes if your checkout misfunctions.  Thanks.