CQ: catch IOError thrown on socket timeouts

commit-queue/verification/try_job_on_rietveld.py

Index: commit-queue/verification/try_job_on_rietveld.py
===================================================================
--- commit-queue/verification/try_job_on_rietveld.py	(revision 233311)
+++ commit-queue/verification/try_job_on_rietveld.py	(working copy)
@@ -754,6 +754,12 @@
         return False
       else:
         raise
+    except IOError as e:
+      # Temporary AppEngine hiccup. Just log it and return failure.
+      if e.errno == 'socket error':

[Vadim Sh., 2013/11/08 19:33:57]

errno is a string?.. How can this happen?

[Paweł Hajdan Jr., 2013/11/08 20:14:19]

I believe it can. All of this is based on what I've seen happening.

When I see the other errors I'll add appropriate error handling. I prefer not to
be too speculative about this.

+        logging.warning(str(e))
+        return False
+      raise
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]