CQ: catch IOError thrown on socket timeouts

commit-queue/verification/try_job_on_rietveld.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Sends patches to the Try server and reads back results.
 
 - RietveldTryJobs contains RietveldTryJob, one per try job on a builder.
 - TryRunnerRietveld uses Rietveld to signal and poll job results.
 """
 
@@ skipping 729 matching lines @@
           status,
           self.context.checkout,
           now)
     except urllib2.HTTPError as e:
       if e.code in (500, 502, 503):
         # Temporary AppEngine hiccup. Just log it and return failure.
         logging.warning(str(e))
         return False
       else:
         raise
+    except IOError as e:
+      # Temporary AppEngine hiccup. Just log it and return failure.
+      if e.errno == 'socket error':
+        logging.warning(str(e))
+        return False
+      raise
     except socket.error as e:

[M-A Ruel, 2013/11/07 19:36:05]

I think socket.error inherits from IOError, so this code will never be executed.
Right? I'd recommend to reverse the order anyway.

[Paweł Hajdan Jr., 2013/11/07 21:02:16]

In my tests it didn't behave that way. I think sometimes python makes IOError
wrap socket.error or something similar.

Reversed the order for now. I'll test some more though.

       # Temporary AppEngine hiccup. Just log it and return failure.
       if e.errno == errno.ECONNRESET:
         logging.warning(str(e))
         return False
       else:
         raise
     if handle:
       for updated_key in keys:
         job = jobs.try_jobs[updated_key]
         self._update_dashboard(pending, job, status)
         jobs.signal_as_failed_if_needed(job, self._build_status_url(job), now)
 
     return True