Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 649713002: Use the correct null constants for Mach threads, tasks, and hosts (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Use the correct null constants for Mach threads, tasks, and hosts. This uses THREAD_NULL, TASK_NULL, and HOST_NULL in preference to MACH_PORT_NULL and kMachPortNull. These constants are correctly-typed (thread_t, task_t, and host_t) and result in more readable source code, especially where thread and task parameters appear together as they do in exc_*_variants. TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8c7872e9e0218ba2a86f546826e8be78521abfed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -43 lines) Patch
M tools/exception_port_tool.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M util/mac/process_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M util/mach/exc_client_variants.h View 1 chunk +1 line, -1 line 0 comments Download
M util/mach/exc_client_variants_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M util/mach/exc_server_variants.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M util/mach/exc_server_variants_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M util/mach/exception_ports.h View 2 chunks +9 lines, -8 lines 0 comments Download
M util/mach/exception_ports.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M util/mach/exception_ports_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-10 18:00:14 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-13 15:03:01 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-13 16:59:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8c7872e9e0218ba2a86f546826e8be78521abfed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698