Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: util/mach/exc_client_variants_test.cc

Issue 649713002: Use the correct null constants for Mach threads, tasks, and hosts (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/exc_client_variants.h ('k') | util/mach/exc_server_variants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exc_client_variants_test.cc
diff --git a/util/mach/exc_client_variants_test.cc b/util/mach/exc_client_variants_test.cc
index 0070880a086a483ec9b2e8af7ecadc5ed9a94d73..82e6363d1a63dbe4ee4752da4dfc99ef816e516c 100644
--- a/util/mach/exc_client_variants_test.cc
+++ b/util/mach/exc_client_variants_test.cc
@@ -70,11 +70,11 @@ class TestExcClientVariants : public UniversalMachExcServer,
EXPECT_EQ(LocalPort(), exception_port);
if (HasIdentity()) {
- EXPECT_NE(kMachPortNull, thread);
+ EXPECT_NE(THREAD_NULL, thread);
EXPECT_EQ(ChildTask(), task);
} else {
- EXPECT_EQ(kMachPortNull, thread);
- EXPECT_EQ(kMachPortNull, task);
+ EXPECT_EQ(THREAD_NULL, thread);
+ EXPECT_EQ(TASK_NULL, task);
}
mach_exception_code_t expect_code = exception_code_;
@@ -153,8 +153,8 @@ class TestExcClientVariants : public UniversalMachExcServer,
exception_subcode_
};
- thread_t thread = MACH_PORT_NULL;
- task_t task = MACH_PORT_NULL;
+ thread_t thread = THREAD_NULL;
+ task_t task = TASK_NULL;
if (all_fields_ || HasIdentity()) {
thread = MachThreadSelf();
task = mach_task_self();
« no previous file with comments | « util/mach/exc_client_variants.h ('k') | util/mach/exc_server_variants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698