Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: util/mach/exception_ports_test.cc

Issue 649713002: Use the correct null constants for Mach threads, tasks, and hosts (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/exception_ports.cc ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/exception_ports_test.cc
diff --git a/util/mach/exception_ports_test.cc b/util/mach/exception_ports_test.cc
index 56cda3c25fd16377af08167e3cbe9ce77ce28ff1..7e98a41d1e4bb2133207749e2f1926bc8fb654cd 100644
--- a/util/mach/exception_ports_test.cc
+++ b/util/mach/exception_ports_test.cc
@@ -212,9 +212,9 @@ class TestExceptionPorts : public UniversalMachExcServer,
void Run() {
ExceptionPorts self_task_ports(ExceptionPorts::kTargetTypeTask,
- MACH_PORT_NULL);
+ TASK_NULL);
ExceptionPorts self_thread_ports(ExceptionPorts::kTargetTypeThread,
- MACH_PORT_NULL);
+ THREAD_NULL);
mach_port_t remote_port = test_exception_ports_->RemotePort();
@@ -285,7 +285,7 @@ class TestExceptionPorts : public UniversalMachExcServer,
// Runs the “other” thread.
void* ThreadMain() {
ExceptionPorts self_thread_ports(ExceptionPorts::kTargetTypeThread,
- MACH_PORT_NULL);
+ THREAD_NULL);
mach_port_t remote_port = test_exception_ports_->RemotePort();
// Set this thread’s exception handler, if appropriate.
@@ -560,7 +560,7 @@ TEST(ExceptionPorts, HostExceptionPorts) {
}
ExceptionPorts implicit_host_ports(ExceptionPorts::kTargetTypeHost,
- MACH_PORT_NULL);
+ HOST_NULL);
EXPECT_EQ("host", implicit_host_ports.TargetTypeName());
rv = implicit_host_ports.GetExceptionPorts(
« no previous file with comments | « util/mach/exception_ports.cc ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698