Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 64933002: Eliminate Shell::RootWindowList in favor of aura::Window::Windows. (Closed)

Created:
7 years, 1 month ago by Ben Goodger (Google)
Modified:
6 years, 11 months ago
Reviewers:
varkha, oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org
Visibility:
Public.

Description

Eliminate Shell::RootWindowList in favor of aura::Window::Windows. This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233970

Patch Set 1 #

Patch Set 2 : bustage #

Patch Set 3 : moar bustage #

Patch Set 4 : try bustage #

Patch Set 5 : even moar bustage #

Patch Set 6 : still moar bustage #

Patch Set 7 : . #

Patch Set 8 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -261 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/debug.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/display_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/display/display_controller.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 4 chunks +23 lines, -20 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M ash/display/output_configurator_animation.h View 1 2 3 4 2 chunks +2 lines, -1 line 1 comment Download
M ash/display/output_configurator_animation.cc View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M ash/display/screen_position_controller.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 4 chunks +20 lines, -12 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_interactive_uitest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 19 chunks +28 lines, -26 lines 0 comments Download
M ash/high_contrast/high_contrast_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/high_contrast/high_contrast_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ash/shell_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 2 3 4 5 7 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_overview.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/partial_screenshot_view.h View 2 chunks +1 line, -5 lines 0 comments Download
M ash/wm/partial_screenshot_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/multi_user_window_manager.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 4 5 6 9 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
lgtm
7 years, 1 month ago (2013-11-07 18:57:11 UTC) #1
Ben Goodger (Google)
Committed patchset #7 manually as r233787 (presubmit successful).
7 years, 1 month ago (2013-11-08 05:53:29 UTC) #2
Ben Goodger (Google)
Committed patchset #8 manually as r233970 (presubmit successful).
7 years, 1 month ago (2013-11-08 20:33:22 UTC) #3
varkha
https://codereview.chromium.org/64933002/diff/440001/ash/display/output_configurator_animation.h File ash/display/output_configurator_animation.h (right): https://codereview.chromium.org/64933002/diff/440001/ash/display/output_configurator_animation.h#newcode16 ash/display/output_configurator_animation.h:16: class RootWindow; Is this still necessary?
6 years, 11 months ago (2014-01-06 21:06:44 UTC) #4
Ben Goodger (Google)
6 years, 11 months ago (2014-01-07 18:50:08 UTC) #5
Message was sent while issue was closed. 
On 2014/01/06 21:06:44, varkha wrote:
>
https://codereview.chromium.org/64933002/diff/440001/ash/display/output_confi...
> File ash/display/output_configurator_animation.h (right):
> 
>
https://codereview.chromium.org/64933002/diff/440001/ash/display/output_confi...
> ash/display/output_configurator_animation.h:16: class RootWindow;
> Is this still necessary?

Probably not.

Powered by Google App Engine
This is Rietveld 408576698