Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2039)

Unified Diff: ash/display/display_controller_unittest.cc

Issue 64933002: Eliminate Shell::RootWindowList in favor of aura::Window::Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/display/display_controller_unittest.cc
diff --git a/ash/display/display_controller_unittest.cc b/ash/display/display_controller_unittest.cc
index a422109f4737061d65ff533902e6d481ee63663b..e45db13345564a8e5e18d3e72c10bedb3d7b281b 100644
--- a/ash/display/display_controller_unittest.cc
+++ b/ash/display/display_controller_unittest.cc
@@ -282,7 +282,7 @@ float GetStoredUIScale(int64 id) {
void GetPrimaryAndSeconary(aura::Window** primary,
aura::Window** secondary) {
*primary = Shell::GetPrimaryRootWindow();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
*secondary = root_windows[0] == *primary ? root_windows[1] : root_windows[0];
}
@@ -905,7 +905,7 @@ TEST_F(DisplayControllerTest, OverscanInsets) {
UpdateDisplay("120x200,300x400*2");
gfx::Display display1 = Shell::GetScreen()->GetPrimaryDisplay();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
display_controller->SetOverscanInsets(display1.id(),
gfx::Insets(10, 15, 20, 25));
@@ -931,12 +931,14 @@ TEST_F(DisplayControllerTest, OverscanInsets) {
UpdateDisplay("400x300*2,600x400/o");
root_windows = Shell::GetAllRootWindows();
gfx::Point point;
- Shell::GetAllRootWindows()[1]->GetRootTransform().TransformPoint(&point);
+ Shell::GetAllRootWindows()[1]->GetDispatcher()->
+ GetRootTransform().TransformPoint(&point);
EXPECT_EQ("15,10", point.ToString());
display_controller->SwapPrimaryDisplay();
point.SetPoint(0, 0);
- Shell::GetAllRootWindows()[1]->GetRootTransform().TransformPoint(&point);
+ Shell::GetAllRootWindows()[1]->GetDispatcher()->
+ GetRootTransform().TransformPoint(&point);
EXPECT_EQ("15,10", point.ToString());
Shell::GetInstance()->RemovePreTargetHandler(&event_handler);
@@ -954,7 +956,7 @@ TEST_F(DisplayControllerTest, Rotate) {
UpdateDisplay("120x200,300x400*2");
gfx::Display display1 = Shell::GetScreen()->GetPrimaryDisplay();
int64 display2_id = ScreenAsh::GetSecondaryDisplay().id();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
aura::test::EventGenerator generator1(root_windows[0]);
EXPECT_EQ("120x200", root_windows[0]->bounds().size().ToString());
@@ -1026,7 +1028,7 @@ TEST_F(DisplayControllerTest, ScaleRootWindow) {
gfx::Display::SetInternalDisplayId(display1.id());
gfx::Display display2 = ScreenAsh::GetSecondaryDisplay();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ("0,0 450x300", display1.bounds().ToString());
EXPECT_EQ("0,0 450x300", root_windows[0]->bounds().ToString());
EXPECT_EQ("450,0 500x300", display2.bounds().ToString());
@@ -1060,8 +1062,8 @@ TEST_F(DisplayControllerTest, TouchScale) {
UpdateDisplay("200x200*2");
gfx::Display display = Shell::GetScreen()->GetPrimaryDisplay();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
- aura::RootWindow* root_window = root_windows[0];
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
+ aura::Window* root_window = root_windows[0];
aura::test::EventGenerator generator(root_window);
generator.PressMoveAndReleaseTouchTo(50, 50);
@@ -1093,7 +1095,7 @@ TEST_F(DisplayControllerTest, ConvertHostToRootCoords) {
UpdateDisplay("600x400*2/r@1.5");
gfx::Display display1 = Shell::GetScreen()->GetPrimaryDisplay();
- Shell::RootWindowList root_windows = Shell::GetAllRootWindows();
+ aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ("0,0 300x450", display1.bounds().ToString());
EXPECT_EQ("0,0 300x450", root_windows[0]->bounds().ToString());
EXPECT_EQ(1.5f, GetStoredUIScale(display1.id()));

Powered by Google App Engine
This is Rietveld 408576698