Added SuspendableScriptExecutor::createAndRun to replace ctor+run

Added SuspendableScriptExecutor::createAndRun to replace ctor+run

R=vsevik@chromium.org,aandrey@chromium.org,pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184344

[kozyatinskiy1, 2014-10-24 08:04:11]

The patch is based on the Andrey's tip:
https://codereview.chromium.org/660863002/
Andrey and Vsevolod, please take a look.

[vsevik, 2014-10-24 08:34:27]

The CQ bit was checked by vsevik@chromium.org

[vsevik, 2014-10-24 08:34:27]

lgtm

[commit-bot: I haz the power, 2014-10-24 08:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649183010/1

[vsevik, 2014-10-24 08:35:05]

The CQ bit was unchecked by vsevik@chromium.org

[vsevik, 2014-10-24 08:35:25]

The CQ bit was checked by vsevik@chromium.org

[commit-bot: I haz the power, 2014-10-24 08:35:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649183010/1

[commit-bot: I haz the power, 2014-10-24 08:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-24 08:43:38]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[kozyatinskiy1, 2014-10-24 09:05:13]

kozyatinskiy@google.com changed reviewers:
+ pfeldman@chromium.org

[kozyatinskiy1, 2014-10-24 09:05:40]

Pavel, I need owner review for web/* files. PTAL.

[aandrey, 2014-10-24 09:22:01]

https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
File Source/web/SuspendableScriptExecutor.h (right):

https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
Source/web/SuspendableScriptExecutor.h:22: virtual void resume() override;
should these be private as well?
what if I call resume() twice?

[pfeldman, 2014-10-24 09:27:42]

rs lgtm

[kozyatinskiy1, 2014-10-24 09:43:39]

https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
File Source/web/SuspendableScriptExecutor.h (right):

https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
Source/web/SuspendableScriptExecutor.h:22: virtual void resume() override;
On 2014/10/24 09:22:00, aandrey wrote:
> should these be private as well?
> what if I call resume() twice?

This method is public in base class and someone always can cast pointer to base
class and call this method. This method uses by notifier to notify this object
about context resumed event.
Now we can receive pointer to this object and can't call method resume manually.

[kozyatinskiy1, 2014-10-24 09:44:11]

The CQ bit was checked by kozyatinskiy@google.com

[kozyatinskiy1, 2014-10-24 09:44:14]

The CQ bit was unchecked by kozyatinskiy@google.com

[kozyatinskiy1, 2014-10-24 09:49:53]

On 2014/10/24 09:43:39, kozyatinskiy wrote:
>
https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
> File Source/web/SuspendableScriptExecutor.h (right):
> 
>
https://codereview.chromium.org/649183010/diff/1/Source/web/SuspendableScript...
> Source/web/SuspendableScriptExecutor.h:22: virtual void resume() override;
> On 2014/10/24 09:22:00, aandrey wrote:
> > should these be private as well?
> > what if I call resume() twice?
> 
> This method is public in base class and someone always can cast pointer to
base
> class and call this method. This method uses by notifier to notify this object
> about context resumed event.
> Now we can receive pointer to this object and can't call method resume
manually.

can't receive pointer*

[kozyatinskiy1, 2014-10-24 09:50:55]

The CQ bit was checked by kozyatinskiy@google.com

[commit-bot: I haz the power, 2014-10-24 09:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/649183010/1

[commit-bot: I haz the power, 2014-10-24 09:55:48]

Committed patchset #1 (id:1) as 184344