Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Unified Diff: Source/web/SuspendableScriptExecutor.h

Issue 649183010: Added SuspendableScriptExecutor::createAndRun to replace ctor+run (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@a
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/SuspendableScriptExecutor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/SuspendableScriptExecutor.h
diff --git a/Source/web/SuspendableScriptExecutor.h b/Source/web/SuspendableScriptExecutor.h
index b2d8489c72f355115ae3020fb9c54c4093a7896b..0ddefd23fd8b3b8474e7790123f1fb0715ebfdca 100644
--- a/Source/web/SuspendableScriptExecutor.h
+++ b/Source/web/SuspendableScriptExecutor.h
@@ -17,17 +17,16 @@ class WebScriptExecutionCallback;
class SuspendableScriptExecutor final : public ActiveDOMObject {
public:
- SuspendableScriptExecutor(LocalFrame*, int worldID, const Vector<ScriptSourceCode>& sources, int extensionGroup, bool userGesture, WebScriptExecutionCallback*);
- virtual ~SuspendableScriptExecutor();
-
- // this method must be called only once
- void run();
+ static void createAndRun(LocalFrame*, int worldID, const Vector<ScriptSourceCode>& sources, int extensionGroup, bool userGesture, WebScriptExecutionCallback*);
virtual void resume() override;
aandrey 2014/10/24 09:22:00 should these be private as well? what if I call re
kozyatinskiy1 2014/10/24 09:43:39 This method is public in base class and someone al
-
virtual void contextDestroyed() override;
private:
+ SuspendableScriptExecutor(LocalFrame*, int worldID, const Vector<ScriptSourceCode>& sources, int extensionGroup, bool userGesture, WebScriptExecutionCallback*);
+ virtual ~SuspendableScriptExecutor();
+
+ void run();
void executeAndDestroySelf();
LocalFrame* m_frame;
« no previous file with comments | « no previous file | Source/web/SuspendableScriptExecutor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698