Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/browser/android/date_time_chooser_android.h

Issue 64913002: Transfer date/time value to chooser as double (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@datetime3
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/date_time_chooser_android.cc » ('j') | content/common/view_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/date_time_chooser_android.h
diff --git a/content/browser/android/date_time_chooser_android.h b/content/browser/android/date_time_chooser_android.h
index a5578e01b86425963cb39cf5c801c7f11551ccd3..03c205949c5387841fa1c237ee6d556c7fc2c087 100644
--- a/content/browser/android/date_time_chooser_android.h
+++ b/content/browser/android/date_time_chooser_android.h
@@ -24,15 +24,8 @@ class DateTimeChooserAndroid {
// DateTimeChooser implementation:
void ShowDialog(ContentViewCore* content,
RenderViewHost* host,
- int type,
- int year,
- int month,
- int day,
- int hour,
- int minute,
- int second,
- int milli,
- int week,
+ int dialog_type,
+ double current_value,
double min,
double max,
double step);
@@ -40,15 +33,7 @@ class DateTimeChooserAndroid {
// Replaces the current value with the one passed the different fields
Miguel Garcia 2013/11/11 13:40:05 nit: change comment
keishi 2013/11/19 12:51:21 Done.
void ReplaceDateTime(JNIEnv* env,
Miguel Garcia 2013/11/11 13:40:05 nit: give names to the different values so they ma
keishi 2013/11/19 12:51:21 Done.
jobject,
- jint dialog_type,
Miguel Garcia 2013/11/11 13:40:05 don't you need dialog_type?
keishi 2013/11/19 12:51:21 The dialog_type would be useful when the replaceDa
- jint year,
- jint month,
- jint day,
- jint hour,
- jint minute,
- jint second,
- jint milli,
- jint week);
+ jdouble);
// Closes the dialog without propagating any changes.
void CancelDialog(JNIEnv* env, jobject);
« no previous file with comments | « no previous file | content/browser/android/date_time_chooser_android.cc » ('j') | content/common/view_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698