Transfer date/time value to chooser as double

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 0eeff755463bbafe3beb51b53916431b9812962b..04f816c38c2f8f6e6f822bb2cf31fca0b6035f5c 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -388,15 +388,8 @@ IPC_STRUCT_BEGIN(ViewHostMsg_CreateWorker_Params)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeDialogValue_Params)
-  IPC_STRUCT_MEMBER(int, dialog_type)
-  IPC_STRUCT_MEMBER(int, year)
-  IPC_STRUCT_MEMBER(int, month)
-  IPC_STRUCT_MEMBER(int, day)
-  IPC_STRUCT_MEMBER(int, hour)
-  IPC_STRUCT_MEMBER(int, minute)
-  IPC_STRUCT_MEMBER(int, second)
-  IPC_STRUCT_MEMBER(int, milli)
-  IPC_STRUCT_MEMBER(int, week)
+  IPC_STRUCT_MEMBER(ui::TextInputType, dialog_type)
+  IPC_STRUCT_MEMBER(double, current_value)

[miu, 2013/11/08 01:48:02]

Drive-by comment: "current_value" isn't very descriptive here.  Is this seconds
since unix epoch?  Also, have you considered using base::Time instead of double?

[keishi, 2013/11/08 02:13:07]

It depends on the dialog_type. If it is "date", "datetime-local", "week" then it
is ms since epoch, for "month" it is months since epoch, "time" is ms since
midnight.
The conversion to double is defined by the HTML spec so it is well defined and
we don't have to do any conversions when crossing the Blink/chromium barrier. We
were already transferring min/max as doubles so we are just sharing that code.
But technically we can use base::Time instead of double here.

[Miguel Garcia, 2013/11/11 13:40:05]

since you have dialog_type already how about naming this dialog_value?

On 2013/11/08 02:13:07, keishi1 wrote:

[keishi, 2013/11/19 12:51:21]

Done.

   IPC_STRUCT_MEMBER(double, minimum)
   IPC_STRUCT_MEMBER(double, maximum)
   IPC_STRUCT_MEMBER(double, step)
@@ -963,7 +956,7 @@ IPC_MESSAGE_ROUTED1(ViewMsg_SetBrowserRenderingStats,
 
 // Replaces a date time input field.
 IPC_MESSAGE_ROUTED1(ViewMsg_ReplaceDateTime,
-                    ViewHostMsg_DateTimeDialogValue_Params /* value */)
+                    double /* value */)
 
 // Copies the image at location x, y to the clipboard (if there indeed is an
 // image at that location).