Transfer date/time value to chooser as double

content/browser/android/date_time_chooser_android.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
 #define CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_
 
 #include <string>
 
 #include "base/android/jni_helper.h"
 #include "base/memory/scoped_ptr.h"
 
 namespace content {
 
 class ContentViewCore;
 class RenderViewHost;
 
 // Android implementation for DateTimeChooser dialogs.
 class DateTimeChooserAndroid {
  public:
   DateTimeChooserAndroid();
   ~DateTimeChooserAndroid();
 
   // DateTimeChooser implementation:
   void ShowDialog(ContentViewCore* content,
                   RenderViewHost* host,
-                  int type,
-                  int year,
-                  int month,
-                  int day,
-                  int hour,
-                  int minute,
-                  int second,
-                  int milli,
-                  int week,
+                  int dialog_type,
+                  double current_value,
                   double min,
                   double max,
                   double step);
 
   // Replaces the current value with the one passed the different fields

[Miguel Garcia, 2013/11/11 13:40:05]

nit: change comment

[keishi, 2013/11/19 12:51:21]

Done.

   void ReplaceDateTime(JNIEnv* env,

[Miguel Garcia, 2013/11/11 13:40:05]

nit: give names to the different values so they match the cc file. Also I think
they all fit in one line now

[keishi, 2013/11/19 12:51:21]

Done.

                        jobject,
-                       jint dialog_type,

[Miguel Garcia, 2013/11/11 13:40:05]

don't you need dialog_type?

[keishi, 2013/11/19 12:51:21]

The dialog_type would be useful when the replaceDateTime call is recieved by a
different RendererDateTimePicker than the one that opened the dialog. To be more
accurate I added an identifier to RendererDateTimePicker. The identifier is sent
to the browser process in ViewHostMsg_OpenDateTimeDialog and is sent back in
ViewMsg_ReplaceDateTime. RendererDateTimePicker can ignore the replaceDateTime
message if the identifier doesn't match.

I had to do the same thing for renderer_webcolorchooser_impl

-                       jint year,
-                       jint month,
-                       jint day,
-                       jint hour,
-                       jint minute,
-                       jint second,
-                       jint milli,
-                       jint week);
+                       jdouble);
 
   // Closes the dialog without propagating any changes.
   void CancelDialog(JNIEnv* env, jobject);
 
   // Propagates the different types of accepted date/time values to the
   // java side.
   static void InitializeDateInputTypes(
        int text_input_type_date, int text_input_type_date_time,
        int text_input_type_date_time_local, int text_input_type_month,
        int text_input_type_time, int text_input_type_week);
 
  private:
   RenderViewHost* host_;
 
   base::android::ScopedJavaGlobalRef<jobject> j_date_time_chooser_;
 
   DISALLOW_COPY_AND_ASSIGN(DateTimeChooserAndroid);
 };
 
 // Native JNI methods
 bool RegisterDateTimeChooserAndroid(JNIEnv* env);
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ANDROID_DATE_TIME_CHOOSER_ANDROID_H_