Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 649123003: [ServiceWorkerCache] Enable ServiceWorkerCache (Closed)

Created:
6 years, 1 month ago by jkarlin
Modified:
6 years, 1 month ago
Reviewers:
jsbell, dglazkov
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorkerCache] Enable ServiceWorkerCache This is tentative per TPM guidance and will be reverted if the intent-to-ship sinks or the feature is found too unstable. BUG=426977 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184386

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jsbell
Looks like you need to rebase on r184340
6 years, 1 month ago (2014-10-24 19:43:41 UTC) #2
jkarlin
On 2014/10/24 19:43:41, jsbell wrote: > Looks like you need to rebase on r184340 Yep ...
6 years, 1 month ago (2014-10-24 19:47:22 UTC) #3
jkarlin
dglazkov@chromium.org: Please review changes in all. Thanks!
6 years, 1 month ago (2014-10-24 19:49:31 UTC) #5
dglazkov
On 2014/10/24 at 19:49:31, jkarlin wrote: > dglazkov@chromium.org: Please review changes in all. > > ...
6 years, 1 month ago (2014-10-24 19:51:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649123003/20001
6 years, 1 month ago (2014-10-24 21:16:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 184386
6 years, 1 month ago (2014-10-24 22:30:59 UTC) #9
horo
6 years, 1 month ago (2014-10-25 02:01:29 UTC) #10
Message was sent while issue was closed.
On 2014/10/24 22:30:59, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as 184386

I reverted this patch because my patch for the directory restriction of
ServiceWorker scope (https://codereview.chromium.org/672383003/) was reverted.
We should not enable ServiceWorker without this restriction for security reason.

I'm creating patches for the directory restriction.
I will re-enable ServiceWorker after these patches will land.
[1/3 blink] https://codereview.chromium.org/674133004/
 Update LayoutTests to be subject to the directory restrictions.
[2/3 chromium] https://codereview.chromium.org/674133004/
 Introduce the directory restriction in Chromium side.
[3/3 blink] https://codereview.chromium.org/681483004/
 Introduce the directory restriction in Blink side and update LayoutTest.

Powered by Google App Engine
This is Rietveld 408576698