Issue 648713003: Change CheckPatchFormatted to report which directory failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648713003: Change CheckPatchFormatted to report which directory failed. (Closed)

Created:
6 years, 2 months ago by jkarlin

Modified:
6 years, 2 months ago

Reviewers:
Dirk Pranke, Ben Goodger (Google)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Project:
tools

Visibility:
Public.

More Reviews

Description

Change CheckPatchFormatted to report which directory failed. If presubmit.py for a directory (such as net/) fails due to not being clang formatted, then 'git cl format' needs to be run for that directory, not the entire patch. BUG=422332 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292407