Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: presubmit_canned_checks.py

Issue 648713003: Change CheckPatchFormatted to report which directory failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index 4f0472be1d3bdf66a43229016e0317744d5dc06a..6dfed2bf697fe0c409ede1024dff026848041e10 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -1106,7 +1106,8 @@ def CheckPatchFormatted(input_api, output_api):
code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)
if code == 2:
return [output_api.PresubmitPromptWarning(
- 'Your patch is not formatted, please run git cl format.')]
+ 'The %s directory requires clang-formatting. '
+ 'Please run git cl format %s' % (input_api.basename, input_api.basename))]
# As this is just a warning, ignore all other errors if the user
# happens to have a broken clang-format, doesn't use git, etc etc.
return []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698