presubmit_canned_checks.py - Issue 648713003: Change CheckPatchFormatted to report which directory failed.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: presubmit_canned_checks.py

Issue 648713003: Change CheckPatchFormatted to report which directory failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Generic presubmit checks that can be reused by other presubmit checks."""	5 """Generic presubmit checks that can be reused by other presubmit checks."""

6	6

7 import os as _os	7 import os as _os

8 _HERE = _os.path.dirname(_os.path.abspath(__file__))	8 _HERE = _os.path.dirname(_os.path.abspath(__file__))

9	9

10	10

(...skipping 1088 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1099 snapshot("done")	1099 snapshot("done")

1100 return results	1100 return results

1101	1101

1102	1102

1103 def CheckPatchFormatted(input_api, output_api):	1103 def CheckPatchFormatted(input_api, output_api):

1104 import git_cl	1104 import git_cl

1105 cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]	1105 cmd = ['cl', 'format', '--dry-run', input_api.PresubmitLocalPath()]

1106 code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)	1106 code, _ = git_cl.RunGitWithCode(cmd, suppress_stderr=True)

1107 if code == 2:	1107 if code == 2:

1108 return [output_api.PresubmitPromptWarning(	1108 return [output_api.PresubmitPromptWarning(

1109 'Your patch is not formatted, please run git cl format.')]	1109 'The %s directory requires clang-formatting. '

	1110 'Please run git cl format %s' % (input_api.basename, input_api.basename))]

1110 # As this is just a warning, ignore all other errors if the user	1111 # As this is just a warning, ignore all other errors if the user

1111 # happens to have a broken clang-format, doesn't use git, etc etc.	1112 # happens to have a broken clang-format, doesn't use git, etc etc.

1112 return []	1113 return []

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »