Issue 648703002: Fix type feedback for name-keyed stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648703002: Fix type feedback for name-keyed stores (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -23 lines)			Patch
M	src/ast.h	View		5 chunks	+10 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/ic/ic.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/ic/ic-compiler.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ic/ic-compiler.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/type-info.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	src/type-info.cc	View		2 chunks	+11 lines, -6 lines	0 comments	Download
M	src/typing.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Jakob Kummerow

So much plumbing for such a small change... The interesting bits are ic-compiler.cc and hydrogen.cc. ...

6 years, 2 months ago (2014-10-10 12:35:33 UTC) #2

Jakob Kummerow

6 years, 2 months ago (2014-10-10 13:28:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20002) manually as 24529 (presubmit successful).