Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: src/type-info.h

Issue 648703002: Fix type feedback for name-keyed stores (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/type-info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_TYPE_INFO_H_ 5 #ifndef V8_TYPE_INFO_H_
6 #define V8_TYPE_INFO_H_ 6 #define V8_TYPE_INFO_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/globals.h" 9 #include "src/globals.h"
10 #include "src/types.h" 10 #include "src/types.h"
(...skipping 18 matching lines...) Expand all
29 bool CallIsMonomorphic(TypeFeedbackId aid); 29 bool CallIsMonomorphic(TypeFeedbackId aid);
30 bool KeyedArrayCallIsHoley(TypeFeedbackId id); 30 bool KeyedArrayCallIsHoley(TypeFeedbackId id);
31 bool CallNewIsMonomorphic(int slot); 31 bool CallNewIsMonomorphic(int slot);
32 32
33 // TODO(1571) We can't use ForInStatement::ForInType as the return value due 33 // TODO(1571) We can't use ForInStatement::ForInType as the return value due
34 // to various cycles in our headers. 34 // to various cycles in our headers.
35 // TODO(rossberg): once all oracle access is removed from ast.cc, it should 35 // TODO(rossberg): once all oracle access is removed from ast.cc, it should
36 // be possible. 36 // be possible.
37 byte ForInType(int feedback_vector_slot); 37 byte ForInType(int feedback_vector_slot);
38 38
39 KeyedAccessStoreMode GetStoreMode(TypeFeedbackId id); 39 void GetStoreModeAndKeyType(TypeFeedbackId id,
40 KeyedAccessStoreMode* store_mode,
41 IcCheckType* key_type);
40 42
41 void PropertyReceiverTypes(TypeFeedbackId id, Handle<String> name, 43 void PropertyReceiverTypes(TypeFeedbackId id, Handle<String> name,
42 SmallMapList* receiver_types); 44 SmallMapList* receiver_types);
43 void KeyedPropertyReceiverTypes(TypeFeedbackId id, 45 void KeyedPropertyReceiverTypes(TypeFeedbackId id,
44 SmallMapList* receiver_types, 46 SmallMapList* receiver_types,
45 bool* is_string); 47 bool* is_string);
46 void AssignmentReceiverTypes(TypeFeedbackId id, 48 void AssignmentReceiverTypes(TypeFeedbackId id,
47 Handle<String> name, 49 Handle<String> name,
48 SmallMapList* receiver_types); 50 SmallMapList* receiver_types);
49 void KeyedAssignmentReceiverTypes(TypeFeedbackId id, 51 void KeyedAssignmentReceiverTypes(TypeFeedbackId id,
50 SmallMapList* receiver_types, 52 SmallMapList* receiver_types,
51 KeyedAccessStoreMode* store_mode); 53 KeyedAccessStoreMode* store_mode,
54 IcCheckType* key_type);
52 void CountReceiverTypes(TypeFeedbackId id, 55 void CountReceiverTypes(TypeFeedbackId id,
53 SmallMapList* receiver_types); 56 SmallMapList* receiver_types);
54 57
55 void CollectReceiverTypes(TypeFeedbackId id, 58 void CollectReceiverTypes(TypeFeedbackId id,
56 SmallMapList* types); 59 SmallMapList* types);
57 60
58 static bool CanRetainOtherContext(Map* map, Context* native_context); 61 static bool CanRetainOtherContext(Map* map, Context* native_context);
59 static bool CanRetainOtherContext(JSFunction* function, 62 static bool CanRetainOtherContext(JSFunction* function,
60 Context* native_context); 63 Context* native_context);
61 64
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 Zone* zone_; 122 Zone* zone_;
120 Handle<UnseededNumberDictionary> dictionary_; 123 Handle<UnseededNumberDictionary> dictionary_;
121 Handle<TypeFeedbackVector> feedback_vector_; 124 Handle<TypeFeedbackVector> feedback_vector_;
122 125
123 DISALLOW_COPY_AND_ASSIGN(TypeFeedbackOracle); 126 DISALLOW_COPY_AND_ASSIGN(TypeFeedbackOracle);
124 }; 127 };
125 128
126 } } // namespace v8::internal 129 } } // namespace v8::internal
127 130
128 #endif // V8_TYPE_INFO_H_ 131 #endif // V8_TYPE_INFO_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/type-info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698