chrome/browser/favicon/favicon_service_factory.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service_factory.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_service_factory.h

diff --git a/chrome/browser/favicon/favicon_service_factory.h b/chrome/browser/favicon/favicon_service_factory.h

index a2ad7b6540d4ce6a9bb868f9761277fa282ac360..674e7e94d61130377530cee0676e49e7584c380d 100644

--- a/chrome/browser/favicon/favicon_service_factory.h

+++ b/chrome/browser/favicon/favicon_service_factory.h

@@ -29,12 +29,12 @@ class FaviconServiceFactory : public BrowserContextKeyedServiceFactory {

friend struct DefaultSingletonTraits<FaviconServiceFactory>;

FaviconServiceFactory();

- virtual ~FaviconServiceFactory();

+ ~FaviconServiceFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* profile) const override;

- virtual bool ServiceIsNULLWhileTesting() const override;

+ bool ServiceIsNULLWhileTesting() const override;

DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);

};

« no previous file with comments | « chrome/browser/favicon/favicon_service.h ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »