chrome/browser/favicon/favicon_service_factory.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/favicon/favicon_service_factory.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/favicon/favicon_service.h ('k') | chrome/browser/favicon/favicon_tab_helper.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

7	7

8 #include "base/memory/singleton.h"	8 #include "base/memory/singleton.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"	10 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"

(...skipping 11 matching lines...) Expand all Loading...
22 // the ServiceAccessType definition in profile.h.	22 // the ServiceAccessType definition in profile.h.

23 static FaviconService* GetForProfile(Profile* profile,	23 static FaviconService* GetForProfile(Profile* profile,

24 Profile::ServiceAccessType sat);	24 Profile::ServiceAccessType sat);

25	25

26 static FaviconServiceFactory* GetInstance();	26 static FaviconServiceFactory* GetInstance();

27	27

28 private:	28 private:

29 friend struct DefaultSingletonTraits<FaviconServiceFactory>;	29 friend struct DefaultSingletonTraits<FaviconServiceFactory>;

30	30

31 FaviconServiceFactory();	31 FaviconServiceFactory();

32 virtual ~FaviconServiceFactory();	32 ~FaviconServiceFactory() override;

33	33

34 // BrowserContextKeyedServiceFactory:	34 // BrowserContextKeyedServiceFactory:

35 virtual KeyedService* BuildServiceInstanceFor(	35 KeyedService* BuildServiceInstanceFor(

36 content::BrowserContext* profile) const override;	36 content::BrowserContext* profile) const override;

37 virtual bool ServiceIsNULLWhileTesting() const override;	37 bool ServiceIsNULLWhileTesting() const override;

38	38

39 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);	39 DISALLOW_COPY_AND_ASSIGN(FaviconServiceFactory);

40 };	40 };

41	41

42 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_	42 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_FACTORY_H_

OLD	NEW