chrome/browser/favicon/favicon_service.h - Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service.h

Issue 648653003: Standardize usage of virtual/override/final in chrome/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_service.h

diff --git a/chrome/browser/favicon/favicon_service.h b/chrome/browser/favicon/favicon_service.h

index 8827353c211c48e9b2351e3354c53c769d150082..06c1a66ec29bf9c5095da64abffda5248d4ffa52 100644

--- a/chrome/browser/favicon/favicon_service.h

+++ b/chrome/browser/favicon/favicon_service.h

@@ -30,7 +30,7 @@ class FaviconService : public KeyedService {

// The FaviconClient must outlive the constructed FaviconService.

FaviconService(Profile* profile, FaviconClient* favicon_client);

- virtual ~FaviconService();

+ ~FaviconService() override;

// We usually pass parameters with pointer to avoid copy. This function is a

// helper to run FaviconResultsCallback with pointer parameters.

« no previous file with comments | « chrome/browser/favicon/favicon_handler_unittest.cc ('k') | chrome/browser/favicon/favicon_service_factory.h » ('j') | no next file with comments »