Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 648463002: Remove tab parameter from GrGLSLMulVarBy4f function (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove tab parameter from GrGLSLMulVarBy4f function With pretty printing of shader code, there is no longer a need to explictily have tabs in our code. BUG=skia: Committed: https://skia.googlesource.com/skia/+/089f8de82d6c342faa9170d8c19d8504177bf5fb

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 chunk +3 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
Rob feel free to ignore, I just wanted to test out Ravi's new '*' feature ...
6 years, 2 months ago (2014-10-09 17:08:32 UTC) #3
joshua.litt
On 2014/10/09 17:08:32, egdaniel wrote: > Rob feel free to ignore, I just wanted to ...
6 years, 2 months ago (2014-10-09 17:09:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648463002/100001
6 years, 2 months ago (2014-10-09 17:21:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 17:35:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as 089f8de82d6c342faa9170d8c19d8504177bf5fb

Powered by Google App Engine
This is Rietveld 408576698