src/effects/SkLightingImageFilter.cpp - Issue 648463002: Remove tab parameter from GrGLSLMulVarBy4f function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 648463002: Remove tab parameter from GrGLSLMulVarBy4f function (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index ce787c6ab823da291e4df0caa83d3cd5be459805..4a4665d4812ee22836d1fc1a225142554b1d9281 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -1454,7 +1454,7 @@ void GrGLLightingEffect::emitCode(GrGLProgramBuilder* builder,

fLight->emitLightColor(builder, "surfaceToLight");

fsBuilder->codeAppend(");\n");

SkString modulate;

- GrGLSLMulVarBy4f(&modulate, 2, outputColor, inputColor);

+ GrGLSLMulVarBy4f(&modulate, outputColor, inputColor);

fsBuilder->codeAppend(modulate.c_str());

}

« no previous file with comments | « no previous file | src/effects/SkMagnifierImageFilter.cpp » ('j') | no next file with comments »