Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648283002: [arm] Add support for SMMLA, SMMLS and SMMUL. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[arm] Add support for SMMLA, SMMLS and SMMUL. TEST=cctest,unittests R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24575

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -12 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +27 lines, -3 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/base/bits.h View 1 chunk +18 lines, -0 lines 0 comments Download
M src/base/bits.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 3 chunks +81 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/unittests/base/bits-unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
https://codereview.chromium.org/648283002/diff/1/test/cctest/test-assembler-arm.cc File test/cctest/test-assembler-arm.cc (right): https://codereview.chromium.org/648283002/diff/1/test/cctest/test-assembler-arm.cc#newcode1500 test/cctest/test-assembler-arm.cc:1500: #define TEST_SMMUL(f, x, y) \ Move all the new ...
6 years, 2 months ago (2014-10-13 18:25:48 UTC) #1
Benedikt Meurer
PTAL https://codereview.chromium.org/648283002/diff/1/test/cctest/test-assembler-arm.cc File test/cctest/test-assembler-arm.cc (right): https://codereview.chromium.org/648283002/diff/1/test/cctest/test-assembler-arm.cc#newcode1500 test/cctest/test-assembler-arm.cc:1500: #define TEST_SMMUL(f, x, y) \ Maybe later...
6 years, 2 months ago (2014-10-14 04:49:43 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 2 months ago (2014-10-14 05:01:00 UTC) #4
Benedikt Meurer
6 years, 2 months ago (2014-10-14 05:03:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:180001) manually as 24575 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698