Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 647483004: Do not use zero or empty android:versionCode (Closed)

Created:
6 years, 2 months ago by aruslan
Modified:
6 years, 2 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not use zero or empty android:versionCode This isn't in general recommended by Android, and it's causing problems with some services that need to establish white/black-listing. BUG=422491 Committed: https://crrev.com/ad608226402b04d953f5c7b13966e6a453e20a9e Cr-Commit-Position: refs/heads/master@{#299334}

Patch Set 1 #

Patch Set 2 : update GN as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aruslan
PTAL, thanks!
6 years, 2 months ago (2014-10-11 00:26:49 UTC) #2
cjhopman
lgtm
6 years, 2 months ago (2014-10-11 00:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647483004/40001
6 years, 2 months ago (2014-10-13 17:34:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 2 months ago (2014-10-13 18:53:22 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:54:06 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad608226402b04d953f5c7b13966e6a453e20a9e
Cr-Commit-Position: refs/heads/master@{#299334}

Powered by Google App Engine
This is Rietveld 408576698