Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 647483004: Do not use zero or empty android:versionCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update GN as well. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 6
7 assert(is_android) 7 assert(is_android)
8 8
9 9
10 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 10 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 _native_libs_dir = "//build/android/empty/res" 245 _native_libs_dir = "//build/android/empty/res"
246 if (defined(invoker.native_libs_dir)) { 246 if (defined(invoker.native_libs_dir)) {
247 _native_libs_dir = invoker.native_libs_dir 247 _native_libs_dir = invoker.native_libs_dir
248 } 248 }
249 249
250 _asset_location = "//build/android/empty/res" 250 _asset_location = "//build/android/empty/res"
251 if (defined(invoker.asset_location)) { 251 if (defined(invoker.asset_location)) {
252 _asset_location = invoker.asset_location 252 _asset_location = invoker.asset_location
253 } 253 }
254 254
255 _version_code = "0" 255 _version_code = "1"
256 _version_name = "Developer Build" 256 _version_name = "Developer Build"
257 257
258 _base_apk_path = _base_path + ".apk_intermediates" 258 _base_apk_path = _base_path + ".apk_intermediates"
259 259
260 _resource_packaged_apk_path = _base_apk_path + ".ap_" 260 _resource_packaged_apk_path = _base_apk_path + ".ap_"
261 _packaged_apk_path = _base_apk_path + ".unfinished.apk" 261 _packaged_apk_path = _base_apk_path + ".unfinished.apk"
262 262
263 263
264 _configuration_name = "Release" 264 _configuration_name = "Release"
265 if (is_debug) { 265 if (is_debug) {
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 args += invoker.args 740 args += invoker.args
741 } 741 }
742 rebased_sources = rebase_path(sources, root_build_dir) 742 rebased_sources = rebase_path(sources, root_build_dir)
743 args += [ "--files=$rebased_sources" ] 743 args += [ "--files=$rebased_sources" ]
744 744
745 if (defined(invoker.clear_dir) && invoker.clear_dir) { 745 if (defined(invoker.clear_dir) && invoker.clear_dir) {
746 args += ["--clear"] 746 args += ["--clear"]
747 } 747 }
748 } 748 }
749 } 749 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698