build/config/android/internal_rules.gni - Issue 647483004: Do not use zero or empty android:versionCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/internal_rules.gni

Issue 647483004: Do not use zero or empty android:versionCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update GN as well. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/android/internal_rules.gni

diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni

index ad979025df1dab92ac2d4757a0eb5cc9e6cede58..da77f38f5e0ba26290f9c995e2eec063cef8f47b 100644

--- a/build/config/android/internal_rules.gni

+++ b/build/config/android/internal_rules.gni

@@ -252,7 +252,7 @@ template("create_apk") {

_asset_location = invoker.asset_location

}

- _version_code = "0"

+ _version_code = "1"

_version_name = "Developer Build"

_base_apk_path = _base_path + ".apk_intermediates"

« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »