Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 646943006: Remove mojo/apps/js, it is unused (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove mojo/apps/js, it is unused This code is being developed in the mojo repository but it unused in chromium. R=aa@chromium.org Committed: https://crrev.com/de8ab311bc9374d0ade71f7c167bad61848c7c48 Cr-Commit-Position: refs/heads/master@{#301324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2941 lines) Patch
M mojo/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
D mojo/apps/js/BUILD.gn View 1 chunk +0 lines, -82 lines 0 comments Download
D mojo/apps/js/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/apps/js/application_delegate_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/apps/js/application_delegate_impl.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/apps/js/bindings/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/apps/js/bindings/connection_unittests.js View 1 chunk +0 lines, -261 lines 0 comments Download
D mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/apps/js/bindings/gl/context.h View 1 chunk +0 lines, -77 lines 0 comments Download
D mojo/apps/js/bindings/gl/context.cc View 1 chunk +0 lines, -187 lines 0 comments Download
D mojo/apps/js/bindings/gl/module.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/gl/module.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/apps/js/bindings/monotonic_clock_unittests.js View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/apps/js/bindings/sample_service_unittests.js View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/apps/js/bindings/threading.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/apps/js/bindings/threading.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/apps/js/content_handler_impl.h View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/apps/js/content_handler_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/apps/js/content_handler_main.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/apps/js/js_app.h View 1 chunk +0 lines, -67 lines 0 comments Download
D mojo/apps/js/js_app.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/apps/js/main.js View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/apps/js/mojo.js View 1 chunk +0 lines, -26 lines 0 comments Download
D mojo/apps/js/mojo_bridge_module.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/apps/js/mojo_bridge_module.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/apps/js/mojo_runner_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/apps/js/mojo_runner_delegate.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D mojo/apps/js/standalone_main.cc View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/apps/js/test/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/apps/js/test/handle_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D mojo/apps/js/test/hexdump.js View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/apps/js/test/js_to_cpp.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
D mojo/apps/js/test/js_to_cpp_unittest.cc View 1 chunk +0 lines, -444 lines 0 comments Download
D mojo/apps/js/test/js_to_cpp_unittest.js View 1 chunk +0 lines, -221 lines 0 comments Download
D mojo/apps/js/test/run_apps_js_tests.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M mojo/mojo.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
D mojo/mojo_apps.gypi View 1 chunk +0 lines, -148 lines 0 comments Download
D mojo/mojo_apps_js_unittests.isolate View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
6 years, 1 month ago (2014-10-27 05:52:16 UTC) #1
Aaron Boodman
On 2014/10/27 05:52:16, jamesr wrote: lgtm
6 years, 1 month ago (2014-10-27 05:56:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/646943006/1
6 years, 1 month ago (2014-10-27 05:58:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 07:38:33 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 07:39:18 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/de8ab311bc9374d0ade71f7c167bad61848c7c48
Cr-Commit-Position: refs/heads/master@{#301324}

Powered by Google App Engine
This is Rietveld 408576698