Enable a11y audit for chrome://settings

Enable a11y audit for chrome://settings

Enabled the tests and fixed failure. Failure was due to transition obscuring elements in the UI.

Another failure was caused because there were no labels on the mic and camera drop downs.

Another failure was that there was no captions for a video element. This is used to capture a profile picture in chrome OS, so there wouldn't be any captions. This element is ignored in the a11y audit.

There was also an issue with the dispatching of events in the ensureTransitionEndEvent function that wouldn't allow the event to bubble.

BUG=311866
Committed: https://crrev.com/34a84c6d1269332cc3ae2b8a50af489230c885de
Cr-Commit-Position: refs/heads/master@{#301266}

Committed: https://crrev.com/ca8b4ecfeee16828955ffe5637749272a5989106
Cr-Commit-Position: refs/heads/master@{#305078}

Committed: https://crrev.com/665503577875fc7eebc2f4b442641295e33ccc41
Cr-Commit-Position: refs/heads/master@{#306909}

[hcarmona, 2014-10-21 21:38:44]

hcarmona@chromium.org changed reviewers:
+ dbeam@chromium.org

[hcarmona, 2014-10-21 21:38:44]

Adding Dan as a reviewer for this change.

[Dan Beam, 2014-10-21 23:13:57]

lgtm

https://codereview.chromium.org/646853004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/options_browsertest.js:720: function() {
function() {
  document.addEventListener('webkitTransitionEnd', function f(e) {
    document.removeEventListener('webkitTransitionEnd', f);
    testDone();
  });
},

[hcarmona, 2014-10-22 17:36:20]

https://codereview.chromium.org/646853004/diff/1/chrome/browser/ui/webui/opti...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/1/chrome/browser/ui/webui/opti...
chrome/browser/ui/webui/options/options_browsertest.js:720: function() {
On 2014/10/21 23:13:56, Dan Beam wrote:
> function() {
>   document.addEventListener('webkitTransitionEnd', function f(e) {
>     document.removeEventListener('webkitTransitionEnd', f);
>     testDone();
>   });
> },

Done.

[Dan Beam, 2014-10-25 00:26:28]

what's holding this CL up?

[hcarmona, 2014-10-25 00:39:24]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2014-10-25 00:43:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646853004/20001

[commit-bot: I haz the power, 2014-10-25 02:21:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-25 02:22:14]

Patchset 2 (id:??) landed as
https://crrev.com/34a84c6d1269332cc3ae2b8a50af489230c885de
Cr-Commit-Position: refs/heads/master@{#301266}

[Avi (use Gerrit), 2014-10-25 18:19:42]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/678883002/ by avi@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

started consistently failing OptionsWebUIExtendedTest.CloseOverlay in the build
in which this CL landed. This touches WebUI, and is implicated in many of the
stack traces.

Reverting to try to green the bot..

[hcarmona, 2014-11-06 23:13:57]

The original CL was reverted because the UI was still transitioning.

I was able to reproduce this in chrome OS and found other disabled a11y audits
that should be enabled for settings.

I updated the unit test so that it passes the try bots.

There are 2 overlays that can be transitioning and the test will wait for both
to finish their transition.

[Dan Beam, 2014-11-07 05:43:20]

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/content_options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/content_options_browsertest.js:31:
this.accessibilityAuditConfig.ignoreSelectors('videoWithoutCaptions',
might be useful to somehow make a class that does this automatically... my eyes
are tired of reading all this duplicated code...

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:107: if (--overlayCount
== 0) {
no curlies

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:116: function
waitForTransitionEnd(overlayId) {
this generally seems a bit much for 2 overlays...

https://codereview.chromium.org/646853004/diff/120001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:123: if (overlay.hidden)
{
nit:

  if (!(e.target.id == overlayId && overlay.hidden))
    return;

  ...

https://codereview.chromium.org/646853004/diff/120001/ui/webui/resources/js/u...
File ui/webui/resources/js/util.js (right):

https://codereview.chromium.org/646853004/diff/120001/ui/webui/resources/js/u...
ui/webui/resources/js/util.js:386: cr.dispatchSimpleEvent(el,
'webkitTransitionEnd', true);
:)

[Dan Beam, 2014-11-12 23:46:13]

lgtm

https://codereview.chromium.org/646853004/diff/140001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest_base.js (right):

https://codereview.chromium.org/646853004/diff/140001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest_base.js:4: 
/**
 * @constructor
 * @extends {testing.Test}
 */

[hcarmona, 2014-11-18 22:55:41]

Trybots should be fixed by disabling audit for the failing test on Mac + chrome.
Created Issue 434502 to enable a11y audit for that test since it is not straight
forward.

[Dan Beam, 2014-11-20 18:35:32]

On 2014/11/18 22:55:41, Hector Carmona wrote:
> Trybots should be fixed by disabling audit for the failing test on Mac +
chrome.
> Created Issue 434502 to enable a11y audit for that test since it is not
straight
> forward.

how is it not straight forward?  did you figure out the cause/talk to bondd@
about this?

https://codereview.chromium.org/646853004/diff/160001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/autofill_options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/160001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/autofill_options_browsertest.js:77: GEN('#if
defined(OS_CHROMEOS)');
if (cr.isChromeOS || cr.isMac)

[hcarmona, 2014-11-20 19:42:04]

On 2014/11/20 18:35:32, Dan Beam wrote:
> On 2014/11/18 22:55:41, Hector Carmona wrote:
> > Trybots should be fixed by disabling audit for the failing test on Mac +
> chrome.
> > Created Issue 434502 to enable a11y audit for that test since it is not
> straight
> > forward.
> 
> how is it not straight forward?  did you figure out the cause/talk to bondd@
> about this?

Yes, spoke with bondd@, we found the cause of the issue and decided that the fix
should be separate from this.
We don't have a way to fix it yet but talked about some possibilities.

[Dan Beam, 2014-11-20 19:49:16]

On 2014/11/20 19:42:04, Hector Carmona wrote:
> On 2014/11/20 18:35:32, Dan Beam wrote:
> > On 2014/11/18 22:55:41, Hector Carmona wrote:
> > > Trybots should be fixed by disabling audit for the failing test on Mac +
> > chrome.
> > > Created Issue 434502 to enable a11y audit for that test since it is not
> > straight
> > > forward.
> > 
> > how is it not straight forward?  did you figure out the cause/talk to bondd@
> > about this?
> 
> Yes, spoke with bondd@, we found the cause of the issue and decided that the
fix
> should be separate from this.
> We don't have a way to fix it yet but talked about some possibilities.

fine, lgtm

I don't like this, though.  Had your change landed first, bondd@'s would've been
reverted or not landed if it broke a11y audits.  That and there's always a
non-zero % chance TODO()s never get done.

[hcarmona, 2014-11-20 19:54:37]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2014-11-20 19:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646853004/170001

[commit-bot: I haz the power, 2014-11-20 20:57:26]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2014-11-20 20:58:00]

Patchset 10 (id:??) landed as
https://crrev.com/ca8b4ecfeee16828955ffe5637749272a5989106
Cr-Commit-Position: refs/heads/master@{#305078}

[Mark P, 2014-11-20 23:48:47]

A revert of this CL (patchset #10 id:170001) has been created in
https://codereview.chromium.org/745953002/ by mpearson@chromium.org.

The reason for reverting is: Causes (timeout) failures in
OptionsWebUIExtendedTest.CloseOverlayNoHistory on Windows 7.

Trouble started with this build.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

---

OptionsWebUIExtendedTest.CloseOverlayNoHistory (run #1):
[ RUN      ] OptionsWebUIExtendedTest.CloseOverlayNoHistory

OptionsWebUIExtendedTest.CloseOverlayNoHistory (run #2):
[ RUN      ] OptionsWebUIExtendedTest.CloseOverlayNoHistory
[1616:2160:1120/144446:WARNING:data_reduction_proxy_settings.cc(319)] SPDY proxy
OFF at startup
[4804:2920:1120/144449:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4224:4604:1120/144455:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[1616:2160:1120/144459:INFO:CONSOLE(1283)] "Running TestCase
OptionsWebUIExtendedTest.CloseOverlayNoHistory", source: test_api.js (1283)

OptionsWebUIExtendedTest.CloseOverlayNoHistory (run #3):
[ RUN      ] OptionsWebUIExtendedTest.CloseOverlayNoHistory
[3656:3020:1120/144549:WARNING:data_reduction_proxy_settings.cc(319)] SPDY proxy
OFF at startup
[3552:4476:1120/144552:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3836:4860:1120/144558:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3656:3020:1120/144602:INFO:CONSOLE(1283)] "Running TestCase
OptionsWebUIExtendedTest.CloseOverlayNoHistory", source: test_api.js (1283)

OptionsWebUIExtendedTest.CloseOverlayNoHistory (run #4):
[ RUN      ] OptionsWebUIExtendedTest.CloseOverlayNoHistory
[3408:4740:1120/144634:WARNING:data_reduction_proxy_settings.cc(319)] SPDY proxy
OFF at startup
[3136:3924:1120/144637:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4424:4988:1120/144643:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3408:4740:1120/144647:INFO:CONSOLE(1283)] "Running TestCase
OptionsWebUIExtendedTest.CloseOverlayNoHistory", source: test_api.js (1283).

[Dan Beam, 2014-11-21 05:27:57]

https://codereview.chromium.org/646853004/diff/170001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/autofill_options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/170001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/autofill_options_browsertest.js:78:
this.disableAccessibilityChecks();
link to why you're doing this

[hcarmona, 2014-12-03 00:39:00]

Addressed flaky test that caused revert by changing the wait on the overlays
into 2 functions. 1 function will wait for the top overlay, and the other will
wait for both. The tests were updated to call the appropriate function in order
to wait properly.

While running trybots, found that testing a11y is flaky on testLoadAddress for
Windows. Disabling a11y audit on all platforms for that test. A11y audit to be
enabled by http://crbug.com/434502 .

https://codereview.chromium.org/646853004/diff/170001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/autofill_options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/170001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/autofill_options_browsertest.js:78:
this.disableAccessibilityChecks();
On 2014/11/21 05:27:57, Dan Beam wrote:
> link to why you're doing this

Done.

[Dan Beam, 2014-12-03 00:55:22]

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:117: }
dedupe the cotents of these 2 methods, e.g.:

/** @param {Array<Element>} targets */
function waitUntilHidden(targets) {
  function isHidden(el) { return el.hidden; }
  document.addEventListener('webkitTransitionEnd', function f(e) {
    if (targets.indexOf(e.target) >= 0 && targets.every(isHidden)) {
      document.removeEventListener('webkitTransitionEnd', f);
      testDone();
    }
  });
}

waitUntilHidden([$('overlay-container-1')])
waitUntilHidden([$('overlay-container-1'), $('overlay-container-2')])

[Dan Beam, 2014-12-03 00:55:42]

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:117: }
On 2014/12/03 00:55:22, Dan Beam wrote:
> dedupe the cotents of these 2 methods, e.g.:

contents

> 
> /** @param {Array<Element>} targets */
> function waitUntilHidden(targets) {
>   function isHidden(el) { return el.hidden; }
>   document.addEventListener('webkitTransitionEnd', function f(e) {
>     if (targets.indexOf(e.target) >= 0 && targets.every(isHidden)) {
>       document.removeEventListener('webkitTransitionEnd', f);
>       testDone();
>     }
>   });
> }
> 
> waitUntilHidden([$('overlay-container-1')])
> waitUntilHidden([$('overlay-container-1'), $('overlay-container-2')])

[hcarmona, 2014-12-04 00:12:34]

Removed duplicate logic based on feedback.

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/210001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:117: }
On 2014/12/03 00:55:22, Dan Beam wrote:
> dedupe the cotents of these 2 methods, e.g.:
> 
> /** @param {Array<Element>} targets */
> function waitUntilHidden(targets) {
>   function isHidden(el) { return el.hidden; }
>   document.addEventListener('webkitTransitionEnd', function f(e) {
>     if (targets.indexOf(e.target) >= 0 && targets.every(isHidden)) {
>       document.removeEventListener('webkitTransitionEnd', f);
>       testDone();
>     }
>   });
> }
> 
> waitUntilHidden([$('overlay-container-1')])
> waitUntilHidden([$('overlay-container-1'), $('overlay-container-2')])

Done.

[Dan Beam, 2014-12-04 03:02:35]

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:99:
targets.every(ensureTransitionEndEvent);
nit: forEach() when the return value of the function doesn't matter

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:99:
targets.every(ensureTransitionEndEvent);
i think you meant ensureTransition, no...?

[hcarmona, 2014-12-04 19:18:38]

Applied feedback.

Good catch on the typo: that part of the code is there to prevent flakyness
which is why the trybots didn't catch it.

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:99:
targets.every(ensureTransitionEndEvent);
On 2014/12/04 03:02:35, Dan Beam wrote:
> i think you meant ensureTransition, no...?

Yes, done.

https://codereview.chromium.org/646853004/diff/230001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/options_browsertest.js:99:
targets.every(ensureTransitionEndEvent);
On 2014/12/04 03:02:35, Dan Beam wrote:
> nit: forEach() when the return value of the function doesn't matter

Done.

[Dan Beam, 2014-12-04 20:08:06]

lgtm

[hcarmona, 2014-12-04 21:28:22]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2014-12-04 21:29:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646853004/250001

[commit-bot: I haz the power, 2014-12-04 22:24:37]

Committed patchset #14 (id:250001)

[commit-bot: I haz the power, 2014-12-04 22:25:32]

Patchset 14 (id:??) landed as
https://crrev.com/665503577875fc7eebc2f4b442641295e33ccc41
Cr-Commit-Position: refs/heads/master@{#306909}