chrome/browser/resources/options/content_settings.html - Issue 646853004: Enable a11y audit for chrome://settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings.html

Issue 646853004: Enable a11y audit for chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Apply Feedback pt2 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/options/content_settings.html

diff --git a/chrome/browser/resources/options/content_settings.html b/chrome/browser/resources/options/content_settings.html

index ff039804b753463fe9f47a776ea0eb676f30d390..3d1b10706bd9ab4094ad501257e20611f0e03eba 100644

--- a/chrome/browser/resources/options/content_settings.html

+++ b/chrome/browser/resources/options/content_settings.html

@@ -441,12 +441,16 @@

</div>

<div>

- <span i18n-content="mediaSelectMicLabel"></span>

- <select id="media-select-mic" class="weakrtl"></select>

+ <span id="media-select-mic-label" i18n-content="mediaSelectMicLabel">

+ </span>

+ <select id="media-select-mic" class="weakrtl"

+ aria-labelledby="media-select-mic-label"></select>

</div>

- <span i18n-content="mediaSelectCameraLabel"></span>

- <select id="media-select-camera" class="weakrtl"></select>

+ <span id="media-select-camera-label"

+ i18n-content="mediaSelectCameraLabel"></span>

+ <select id="media-select-camera" class="weakrtl"

+ aria-labelledby="media-select-camera-label"></select>

</div>

<label>

« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/autofill_options_browsertest.js » ('j') | no next file with comments »