Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: chrome/browser/ui/webui/options/autofill_options_browsertest.js

Issue 646853004: Enable a11y audit for chrome://settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Apply Feedback pt2 Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/autofill_options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/autofill_options_browsertest.js b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
index 6efa92bd7fa9a380b06fedc4e2702843561eed00..6da37b9610ef55b01676662825c7e24ef46cd024 100644
--- a/chrome/browser/ui/webui/options/autofill_options_browsertest.js
+++ b/chrome/browser/ui/webui/options/autofill_options_browsertest.js
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+GEN_INCLUDE(['options_browsertest_base.js']);
+
/**
* Returns the HTML element for the |field|.
* @param {string} field The field name for the element.
@@ -30,10 +32,11 @@ function getListSize(list) {
function AutofillOptionsWebUITest() {}
AutofillOptionsWebUITest.prototype = {
- __proto__: testing.Test.prototype,
+ __proto__: OptionsBrowsertestBase.prototype,
/**
* Browse to autofill options.
+ * @override
*/
browsePreload: 'chrome://settings-frame/autofill',
};
@@ -51,7 +54,7 @@ TEST_F('AutofillOptionsWebUITest', 'testOpenAutofillOptions', function() {
function AutofillEditAddressWebUITest() {}
AutofillEditAddressWebUITest.prototype = {
- __proto__: testing.Test.prototype,
+ __proto__: OptionsBrowsertestBase.prototype,
/** @override */
browsePreload: 'chrome://settings-frame/autofillEditAddress',
@@ -70,6 +73,12 @@ TEST_F('AutofillEditAddressWebUITest', 'testInitialFormLayout', function() {
});
TEST_F('AutofillEditAddressWebUITest', 'testLoadAddress', function() {
+ // http://crbug.com/434502
+ // Accessibility failure was originally (and consistently) seen on Mac OS and
+ // Chromium OS. Disabling for all OSs because of a flake in Windows. There is
+ // a possibility for flake in linux too.
+ this.disableAccessibilityChecks();
+
assertEquals(this.browsePreload, document.location.href);
var testAddress = {

Powered by Google App Engine
This is Rietveld 408576698