Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 646273006: Get rid of ScrollView. (Closed)

Created:
6 years, 2 months ago by ojan
Modified:
6 years, 2 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Get rid of ScrollView. We only allow overflow scrolling. The frame isn't special. This is a first step in making that happen. There's a lot of code to remove after this patch, but this gets rid of ScrollView and a bunch of frame-level scrolling code. Had to add in a FrameWidget class so that Scrollbar.cpp had a way of getting to FrameView::removeChild without pulling a core class into platform. This might go away when we rip out the Widget tree if we made it so that FrameView didn't keep a list of Scrollbar instances. Modified scrollbar.html to use overflow scrolling instead of frame level scrolling. Once we get rid of the split between Document and documentElement, we'll be able to make the root element in the page scrollable as well (i.e. any child of the Document). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/352610817aa32b4ac7d2237f8b4cfa8e20db64ea

Patch Set 1 #

Patch Set 2 : merge to ToT #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -1945 lines) Patch
M sky/engine/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 13 chunks +82 lines, -38 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 25 chunks +72 lines, -219 lines 2 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 1 2 chunks +1 line, -17 lines 0 comments Download
M sky/engine/core/frame/LocalFrame.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 29 chunks +42 lines, -119 lines 0 comments Download
M sky/engine/core/page/PageAnimator.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +4 lines, -10 lines 0 comments Download
M sky/engine/core/rendering/ImageQualityController.cpp View 3 chunks +5 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderPart.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 7 chunks +8 lines, -76 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
A sky/engine/platform/FrameWidget.h View 1 chunk +23 lines, -0 lines 0 comments Download
D sky/engine/platform/scroll/ScrollView.h View 1 chunk +0 lines, -330 lines 0 comments Download
D sky/engine/platform/scroll/ScrollView.cpp View 1 chunk +0 lines, -994 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/scroll/Scrollbar.cpp View 3 chunks +4 lines, -13 lines 0 comments Download
M sky/engine/web/WebInputEventConversion.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebInputEventConversion.cpp View 1 5 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/web/WebLocalFrameImpl.cpp View 2 chunks +7 lines, -16 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 5 chunks +8 lines, -27 lines 0 comments Download
M sky/tests/lowlevel/scrollbar.html View 1 chunk +23 lines, -21 lines 0 comments Download
M sky/tests/lowlevel/scrollbar-expected.txt View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
Sorry this is so enormous.
6 years, 2 months ago (2014-10-24 02:43:20 UTC) #2
abarth-chromium
LGTM This means we can remove fixed position too, right? https://codereview.chromium.org/646273006/diff/20001/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (right): https://codereview.chromium.org/646273006/diff/20001/sky/engine/core/frame/FrameView.cpp#newcode1865 ...
6 years, 2 months ago (2014-10-24 03:16:06 UTC) #3
ojan
Committed patchset #2 (id:20001) manually as 352610817aa32b4ac7d2237f8b4cfa8e20db64ea (presubmit successful).
6 years, 2 months ago (2014-10-24 03:20:30 UTC) #4
ojan
6 years, 2 months ago (2014-10-24 03:21:01 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/646273006/diff/20001/sky/engine/core/frame/Fr...
File sky/engine/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/646273006/diff/20001/sky/engine/core/frame/Fr...
sky/engine/core/frame/FrameView.cpp:1865: current != end; ++current) {
On 2014/10/24 03:16:06, abarth wrote:
> for (const auto& widget : m_children) {
>   ...
> }
> 
> For realz

Amazing. Done.

I guess it's time to actually learn C++11 syntax!

Powered by Google App Engine
This is Rietveld 408576698