sky/engine/core/dom/ContainerNode.cpp - Issue 646273006: Get rid of ScrollView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/ContainerNode.cpp

Issue 646273006: Get rid of ScrollView. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: merge to ToT Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/ContainerNode.cpp

diff --git a/sky/engine/core/dom/ContainerNode.cpp b/sky/engine/core/dom/ContainerNode.cpp

index c17335de58b53a2fb338449f451a403ee9d308f0..08efef0b473a3d9a738c5fb655613c086cd33187 100644

--- a/sky/engine/core/dom/ContainerNode.cpp

+++ b/sky/engine/core/dom/ContainerNode.cpp

@@ -831,7 +831,7 @@ bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const

// If the target doesn't have any children or siblings that could be used to calculate the scroll position, we must be

// at the end of the document. Scroll to the bottom. FIXME: who said anything about scrolling?

if (!o && document().view()) {

- point = FloatPoint(0, document().view()->contentsHeight());

+ point = FloatPoint(0, document().view()->height());

return true;

}

return false;