Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6461024: Revert 74292 - Splits ChromeURLDataManager into 2 chunks:... (Closed)

Created:
9 years, 10 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, idana, wez+watch_chromium.org, Raghu Simha, Erik does not do reviews, ajwong+watch_chromium.org, dmaclach+watch_chromium.org, ncarter (slow), garykac+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, tim (not reviewing), brettw-cc_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, davemoore+watch_chromium.org, lambroslambrou+watch_chromium.org
Visibility:
Public.

Description

Revert 74292 - Splits ChromeURLDataManager into 2 chunks: . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. BUG=52022 71868 TEST=none Review URL: http://codereview.chromium.org/6286131 TBR=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+852 lines, -825 lines) Patch
M chrome/browser/browser_about_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 4 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +6 lines, -1 line 0 comments Download
MM chrome/browser/browser_signin.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/imageburner_ui.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc View 2 chunks +6 lines, -3 lines 0 comments Download
MM chrome/browser/chromeos/dom_ui/login/login_ui.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/menu_ui.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/mobile_setup_ui.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dom_ui/network_menu_ui.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/register_page_ui.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/system_info_ui.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/bookmarks_ui.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/bug_report_ui.cc View 5 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.h View 5 chunks +95 lines, -73 lines 0 comments Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 2 chunks +401 lines, -72 lines 0 comments Download
D chrome/browser/dom_ui/chrome_url_data_manager_backend.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/dom_ui/chrome_url_data_manager_backend.cc View 1 chunk +0 lines, -393 lines 0 comments Download
M chrome/browser/dom_ui/conflicts_ui.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/downloads_dom_handler.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/filebrowse_ui.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/flags_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/gpu_internals_ui.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/history2_ui.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/history_ui.cc View 2 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/keyboard_ui.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/mediaplayer_ui.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/most_visited_handler.cc View 1 chunk +19 lines, -10 lines 0 comments Download
M chrome/browser/dom_ui/net_internals_ui.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/options/browser_options_handler.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/options/options_ui.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/print_preview_ui.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/remoting_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
MM chrome/browser/dom_ui/shared_resources_data_source.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/shared_resources_data_source.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/slideshow_ui.cc View 2 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/sync_internals_ui.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/textfields_ui.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/remoting/setup_flow.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_mock.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard.cc View 1 chunk +9 lines, -4 lines 0 comments Download
MM chrome/browser/sync/sync_ui_util_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/testing_profile.cc View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
9 years, 10 months ago (2011-02-09 16:56:05 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698