Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: chrome/browser/browser_signin.cc

Issue 6461024: Revert 74292 - Splits ChromeURLDataManager into 2 chunks:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_shutdown.cc ('k') | chrome/browser/chromeos/dom_ui/imageburner_ui.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Deleted: svn:mergeinfo
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_signin.h" 5 #include "chrome/browser/browser_signin.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/json/json_reader.h" 10 #include "base/json/json_reader.h"
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 signin_->Cancel(); 208 signin_->Cancel();
209 } 209 }
210 signin_->GetProfileSyncService()->OnUserSubmittedAuth( 210 signin_->GetProfileSyncService()->OnUserSubmittedAuth(
211 username, password, captcha, access_code); 211 username, password, captcha, access_code);
212 } 212 }
213 213
214 BrowserSignin::BrowserSignin(Profile* profile) 214 BrowserSignin::BrowserSignin(Profile* profile)
215 : profile_(profile), 215 : profile_(profile),
216 delegate_(NULL), 216 delegate_(NULL),
217 html_dialog_ui_delegate_(NULL) { 217 html_dialog_ui_delegate_(NULL) {
218 // profile is NULL during testing. 218 BrowserSigninResourcesSource* source = new BrowserSigninResourcesSource();
219 if (profile) { 219 BrowserThread::PostTask(
220 BrowserSigninResourcesSource* source = new BrowserSigninResourcesSource(); 220 BrowserThread::IO, FROM_HERE,
221 profile->GetChromeURLDataManager()->AddDataSource(source); 221 NewRunnableMethod(ChromeURLDataManager::GetInstance(),
222 } 222 &ChromeURLDataManager::AddDataSource,
223 make_scoped_refptr(source)));
223 } 224 }
224 225
225 BrowserSignin::~BrowserSignin() { 226 BrowserSignin::~BrowserSignin() {
226 delegate_ = NULL; 227 delegate_ = NULL;
227 } 228 }
228 229
229 void BrowserSignin::RequestSignin(TabContents* tab_contents, 230 void BrowserSignin::RequestSignin(TabContents* tab_contents,
230 const string16& suggested_email, 231 const string16& suggested_email,
231 const string16& login_message, 232 const string16& login_message,
232 SigninDelegate* delegate) { 233 SigninDelegate* delegate) {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 323
323 void BrowserSignin::ShowSigninTabModal(TabContents* tab_contents) { 324 void BrowserSignin::ShowSigninTabModal(TabContents* tab_contents) {
324 // TODO(johnnyg): Need a linux views implementation for ConstrainedHtmlDialog. 325 // TODO(johnnyg): Need a linux views implementation for ConstrainedHtmlDialog.
325 #if defined(OS_WIN) || defined(OS_CHROMEOS) || !defined(TOOLKIT_VIEWS) 326 #if defined(OS_WIN) || defined(OS_CHROMEOS) || !defined(TOOLKIT_VIEWS)
326 html_dialog_ui_delegate_ = CreateHtmlDialogUI(); 327 html_dialog_ui_delegate_ = CreateHtmlDialogUI();
327 ConstrainedHtmlUI::CreateConstrainedHtmlDialog(profile_, 328 ConstrainedHtmlUI::CreateConstrainedHtmlDialog(profile_,
328 html_dialog_ui_delegate_, 329 html_dialog_ui_delegate_,
329 tab_contents); 330 tab_contents);
330 #endif 331 #endif
331 } 332 }
OLDNEW
« no previous file with comments | « chrome/browser/browser_shutdown.cc ('k') | chrome/browser/chromeos/dom_ui/imageburner_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698