Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalFrame.cpp
diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp
index 7c852b36fb9cea1ed03e8351197e60cb2319737b..da06b648fb248c0ed9fa2c5de48bce1b79289d27 100644
--- a/Source/core/frame/LocalFrame.cpp
+++ b/Source/core/frame/LocalFrame.cpp
@@ -309,7 +309,8 @@ void LocalFrame::setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow> domWindow)
// only keep a weak reference to this frame, so there's no need to be
// explicitly notified that this frame is going away.
if (m_domWindow) {
- console().messageStorage()->frameWindowDiscarded(m_domWindow.get());
+ if (host())
+ host()->consoleMessageStorage().frameWindowDiscarded(m_domWindow.get());
InspectorInstrumentation::frameWindowDiscarded(this, m_domWindow.get());
vsevik 2014/10/14 14:34:08 I think this should not be called when host() is n
kozyatinskiy1 2014/10/14 17:17:01 Acknowledged.
}
if (domWindow)

Powered by Google App Engine
This is Rietveld 408576698