Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 645693003: [DevTools] Console Message Storage moved from top local frame to frame host (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/LocalFrame.cpp ('K') | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/inspector/ConsoleMessageStorage.h » ('j') | Source/core/inspector/InspectorInstrumentation.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/Source/core/inspector/CodeGeneratorInstrumentation.py b/Source/core/inspector/CodeGeneratorInstrumentation.py

index 54e5ce8a4359084ecf615103864ac672b957d494..76bada0666730cc03b72abccee0b24d47812e6a0 100755

--- a/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -336,12 +336,14 @@ class Method:

elif self.returns_value:

body_lines.append("\n return %s;" % self.default_return_value)

- cpp_lines.append(template_outofline.substitute(

+ generated = template_outofline.substitute(

vsevik 2014/10/14 14:34:08 Please give it a bit more descriptive name

kozyatinskiy1 2014/10/14 17:17:01 Done.

None,

return_type=self.return_type,

name=self.name,

params_impl=", ".join(map(Parameter.to_str_class_and_name, self.params_impl)),

- impl_lines="".join(body_lines)))

+ impl_lines="".join(body_lines))

+ if generated not in cpp_lines:

+ cpp_lines.append(generated)

def generate_agent_call(self, agent):

agent_class, agent_getter = agent_getter_signature(agent)