[DevTools] Console Message Storage moved from top local frame to frame host

Source/core/frame/LocalFrame.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Simon Hausmann <hausmann@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  *                     2001 George Staikos <staikos@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 291 matching lines @@
     //    signalled the Inspector frameWindowDiscarded() notifications.
     //    We assume that all LocalFrames are detached, where that notification
     //    will have been done.
     //
     //  - Calling LocalDOMWindow::reset() is not needed (called from
     //    Frame::setDOMWindow().) The Member references it clears will now
     //    die with the window. And the registered DOMWindowProperty instances that don't,
     //    only keep a weak reference to this frame, so there's no need to be
     //    explicitly notified that this frame is going away.
     if (m_domWindow) {
-        console().messageStorage()->frameWindowDiscarded(m_domWindow.get());
+        if (host())
+            host()->consoleMessageStorage().frameWindowDiscarded(m_domWindow.get());
         InspectorInstrumentation::frameWindowDiscarded(this, m_domWindow.get());

[vsevik, 2014/10/14 14:34:08]

I think this should not be called when host() is null as well.
However we'd better change this in a separate patch as this is kind of scary.

[kozyatinskiy1, 2014/10/14 17:17:01]

Acknowledged.

     }
     if (domWindow)
         script().clearWindowProxy();
     Frame::setDOMWindow(domWindow);
 }
 
 void LocalFrame::didChangeVisibilityState()
 {
     if (document())
         document()->didChangeVisibilityState();
@@ skipping 455 matching lines @@
 }
 
 void LocalFrame::unregisterPluginElement(HTMLPlugInElement* plugin)
 {
     ASSERT(m_pluginElements.contains(plugin));
     m_pluginElements.remove(plugin);
 }
 #endif
 
 } // namespace blink