Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 645493002: [ia32] Better code generation for materialization of float/double constants. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[ia32] Better code generation for materialization of float/double constants. TEST=cctest,mjsunit R=mstarzinger@chromium.org, jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24485

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -22 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +59 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-09 09:06:55 UTC) #1
Michael Starzinger
LGTM.
6 years, 2 months ago (2014-10-09 09:32:09 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-09 09:33:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698